[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#818595: dasd-config: allow users to re-format DASDs in non-expert mode



Package: s390-dasd
Version: 0.0.35
Severity: normal
Tags: d-i patch

Recently, a change lowered the priority of the question to low-level
format a DASD.  The "low" priority caused the question to be displayed
only in the expert mode (unless debconf priority has been manually
changed).

There are cases where users might want to low-level format a DASD
even if it is already formatted.  For example, if a DASD uses LDL
and the user wants to reformat the DASD as CDL.

Thus, increase the priority to "high" to be always displayed in
non-expert mode again.  Of course, depending on the format status
a meaningful default is set.

Thanks and kind regards,
  Hendrik
>From 00784c5bbd3a88e2ba6a06a1375a214babbdf540 Mon Sep 17 00:00:00 2001
From: Hendrik Brueckner <brueckner@linux.vnet.ibm.com>
Date: Wed, 9 Mar 2016 17:35:20 +0100
Subject: [PATCH] dasd-config: allow users to re-format DASDs in non-expert
 mode

Recently, a change lowered the priority of the question to low-level
format a DASD.  The "low" priority caused the question to be displayed
only in the expert mode (unless debconf priority has been manually
changed).

There are cases where users might want to low-level format a DASD
even if it is already formatted.  For example, if a DASD uses LDL
and the user wants to reformat the DASD as CDL.

Thus, increase the priority to "high" to be always displayed in
non-expert mode again.  Of course, depending on the format status
a meaningful default is set.

Signed-off-by: Hendrik Brueckner <brueckner@linux.vnet.ibm.com>
---
 dasd-config.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/dasd-config.c b/dasd-config.c
index 7ff57c7..9978fee 100644
--- a/dasd-config.c
+++ b/dasd-config.c
@@ -367,7 +367,7 @@ static enum state_wanted format (void)
 	 */
 	debconf_reset (client, template);
 	debconf_subst (client, template, "device", channel_current->name);
-	ret = my_debconf_input (channel_current->formatted ? "low" : "critical",
+	ret = my_debconf_input (channel_current->formatted ? "high" : "critical",
 				template, &ptr);
 
 	if (ret == CMD_GOBACK)
-- 
2.7.0


Reply to: