[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: mangled conditional statement breaks debian in chroots



Cyril Brulebois <kibi@debian.org> writes:

> mat bentley <mathewkbentley@gmail.com> (2016-01-24):
>> This commit at
>> https://anonscm.debian.org/cgit/d-i/debootstrap.git/diff/functions?id=5518b79792dd93a416464c0744b87eb1a32ff770
>> 
>> appears to 100% of the time invoke setup_devices_simple function; which
>> means pre-existing paths can never execute. at worst this led to an issue
>> w/ crouton an installer for ubuntu chroots tailored for chrome os:
>> https://github.com/dnschneid/crouton/issues/2387
>> 
>> and at best - it yields dead code; a sign of sloppy development. if it
>> cannot execute it should be removed.
>
> Maybe that was done on purpose so as not to lose the code entirely, and
> so as to be able to quickly add whatever detection people might need to
> get the old behaviour once they have explained their use case through a
> bug report against debootstrap in the Debian bug tracking system?

BTW here's where the patch came from:

  https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=571136#65

Cheers, Phil.
-- 
|)|  Philip Hands  [+44 (0)20 8530 9560]  HANDS.COM Ltd.
|-|  http://www.hands.com/    http://ftp.uk.debian.org/
|(|  Hugo-Klemm-Strasse 34,   21075 Hamburg,    GERMANY

Attachment: signature.asc
Description: PGP signature


Reply to: