[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#844641: debian-installer: message about security erase does not wrap, loosing essential part at end



Control: reassign -1 partman-crypto

Jonas Smedegaard <dr@jones.dk> (2016-11-17):
> Package: debian-installer
> Severity: normal
> 
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA256
> 
> On weekly snapshot of Stretch netinst image downloaded today, choosing
> an install in danish with full disk encryption, I notice that at the
> screen informing about the many hour long security wipe of the target
> disk the message below the bar is not wrapped - and (at least in danish)
> the important part of the message is cut off:
> 
>  "... Dette trin kan springes over ved a"
> 
> In english: "... This step can be skipped b"

For the sake of completeness:

,---[ debian/po/da.po ]---
| #. Type: text
| #. Description
| #. :sl3:
| #: ../partman-crypto.templates:24001
| msgid ""
| "The installer is now overwriting ${DEVICE} with zeroes to delete its "
| "previous contents. This step may be skipped by cancelling this action."
| msgstr ""
| "Installationsprogrammet overskriver nu ${DEVICE} med nul-tegn for at slette "
| "det tidligere indhold. Dette trin kan udelades ved at afbryde denne handling."
`---

,---[ debian/partman-crypto.templates ]---
| Template: partman-crypto/progress/plain_erase_text
| Type: text
| # :sl3:
| _Description: The installer is now overwriting ${DEVICE} with zeroes to delete its previous contents. This step may be skipped by cancelling this action.
`---

I think it's used here:
,---[ lib/crypto-base.sh ]---
| crypto_do_wipe () {
|         local template dev fifo pid x
|         template=$1
|         dev=$2
|         fifo=/var/run/wipe_progress
| 
|         mknod $fifo p
|         /bin/blockdev-wipe -s $((512*1024)) $dev > $fifo &
|         pid=$!
| 
|         cancelled=0
|         db_capb backup align progresscancel
|         db_progress START 0 1000 ${template}_title
|         db_progress INFO ${template}_text
|         while read x <&9; do
|                 db_progress STEP 1
|                 if [ $? -eq 30 ]; then
|                         cancelled=1
|                         kill $pid
|                         break
|                 fi
|         done 9< $fifo
|         db_progress STOP
|         db_capb backup align
| […]
`---

I can't tell for sure whether it's used properly and/or whether it's
just that the current progress bar implementation isn't supposed to
allow for wrapping.


KiBi.

Attachment: signature.asc
Description: Digital signature


Reply to: