[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#819883: marked as done (debootstrap: please make the build reproducible)

Your message dated Sun, 13 Nov 2016 18:14:50 -0800
with message-id <20161114021450.nm2jl2y4e3vhyha3@tomate.cristau.org>
and subject line Re: Bug#819883: debootstrap: please make the build reproducible
has caused the Debian Bug report #819883,
regarding debootstrap: please make the build reproducible
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
819883: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=819883
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Source: debootstrap
Version: 1.0.80
Severity: wishlist
Tags: patch
User: reproducible-builds@lists.alioth.debian.org
Usertags: fileordering
X-Debbugs-Cc: reproducible-builds@lists.alioth.debian.org

Hi!

While working on the "reproducible builds" effort [1], we have noticed
that debootstrap could not be built reproducibly.
The devices.tar.gz tarball contains devices in unsorted (readdir) order.

The attached patch fixes this by telling tar to sort the archive
members.

Regards,
 Reiner

[1]: https://wiki.debian.org/ReproducibleBuilds

diff --git a/Makefile b/Makefile
index 1020cbc..07682bc 100644
--- a/Makefile
+++ b/Makefile
@@ -36,7 +36,7 @@ devices.tar.gz:
 	chown 0:0 dev
 	chmod 755 dev
 	(cd dev && $(MAKEDEV) std ptmx fd consoleonly)
-	tar --mtime="$(DATE)" -cf - dev | gzip -9n >devices.tar.gz
+	tar --sort=name --mtime="$(DATE)" -cf - dev | gzip -9n >devices.tar.gz
 	@if [ "$$(tar tvf devices.tar.gz | wc -l)" -lt 2 ]; then \
 		echo " ** devices.tar.gz is empty!" >&2; \
 		exit 1; \
diff --git a/debian/control b/debian/control
index 46e2b93..40cfbcd 100644
--- a/debian/control
+++ b/debian/control
@@ -3,7 +3,7 @@ Section: admin
 Priority: extra
 Maintainer: Debian Install System Team <debian-boot@lists.debian.org>
 Uploaders: Junichi Uekawa <dancer@debian.org>, Colin Watson <cjwatson@debian.org>, Christian Perrier <bubulle@debian.org>, Steve McIntyre <93sam@debian.org>
-Build-Depends: debhelper (>= 9), makedev (>= 2.3.1-69) [linux-any]
+Build-Depends: debhelper (>= 9), makedev (>= 2.3.1-69) [linux-any], tar (>= 1.28)
 Standards-Version: 3.9.6
 Vcs-Browser: https://anonscm.debian.org/cgit/d-i/debootstrap.git
 Vcs-Git: https://anonscm.debian.org/git/d-i/debootstrap.git

Attachment: signature.asc
Description: PGP signature


--- End Message ---
--- Begin Message --- 
Version: 1.0.82

On Sun, Apr 03, 2016 at 03:39:00PM +0200, Reiner Herrmann wrote:
> While working on the "reproducible builds" effort [1], we have noticed
> that debootstrap could not be built reproducibly.
> The devices.tar.gz tarball contains devices in unsorted (readdir) order.
> 
Current debootstrap no longer ships devices.tar.gz, closing.

Cheers,
Julien

--- End Message ---
Reply to: