Lennart Sorensen <lsorense@csclub.uwaterloo.ca> (2016-10-31):
> On Sun, Oct 30, 2016 at 05:28:57PM +0100, Cyril Brulebois wrote:
> > The (re)addition of InRelease support broke debootstrap(-udeb) in a d-i
> > context. The sed|tr|sed dance doesn't kill the final newline, which
> > leads to a BAD signature.
>
> The one I proposed certainly did. It worked fine and was portable.
> Just a touch ugly perhaps.
No, the “certainly did” and “worked fine” bits are wrong.
And that's not just me, we've had users report it, Philip Hands saw it
as well. So no it did *NOT* work (in the specific case where it actually
matters).
> > My original proposal was to use head -c -1, which while not specified by
> > posix actually just works. Reasons include:
> > 1. Tests agree.
> > 2. busybox's coreutils/head.c has:
> > case 'c':
> > count_bytes = 1;
> > …
> > if (negative_N) {
> > if (count_bytes) {
> > print_except_N_last_bytes(fp, count);
> > } else {
> > print_except_N_last_lines(fp, count);
> > }
> > } else {
> > print_first_N(fp, count, count_bytes);
> > }
>
> Well only if you have ENABLE_FEATURE_FANCY_HEAD and it was only added
> in 2013, so rather recent addition.
Well that's the case in Debian right now, even in d-i! So your “busybox
head does not appear to support it.” was wrong (that happens, no big
deal), and I'm not so fond of being called a liar when I report test
results for stuff I actually checked.
Anyway, back to getting the next d-i release ready now that this issue
is fixed.
KiBi.
Attachment:
signature.asc
Description: Digital signature