It looks like there are a couple of other instances of the potentially
empty braces problem in this script, so we could address them at the
same time just in case.
Also, if the variable somehow ended up containing just whitespace then
the proposed fix would fail.
How about just adding : to each brace, as in the following patch.
(can always put the : on a line of its own, if people think tacking it
on the brace line is confusing, but it struck me as a waste of space)
--- a/setupcon
+++ b/setupcon
@@ -910,7 +910,7 @@ $commands_f
if ls /dev/fb* >/dev/null 2>/dev/null; then
for i in /dev/vcs[0-9]*; do
- {
+ { :
$commands_f
} < /dev/tty\${i#/dev/vcs} > /dev/tty\${i#/dev/vcs}
done
@@ -919,7 +919,7 @@ fi
mkdir -p /run/console-setup
> /run/console-setup/font-loaded
for i in /dev/vcs[0-9]*; do
- {
+ { :
$commands_t
} < /dev/tty\${i#/dev/vcs} > /dev/tty\${i#/dev/vcs}
done
@@ -927,7 +927,7 @@ EOF
cat >/etc/console-setup/cached_setup_terminal.sh <<EOF
#!/bin/sh
-{
+{ :
$commands_t
} < /dev/tty\${1#vcs} > /dev/tty\${1#vcs}
EOF
--
|)| Philip Hands [+44 (0)20 8530 9560] HANDS.COM Ltd.
|-| http://www.hands.com/ http://ftp.uk.debian.org/
|(| Hugo-Klemm-Strasse 34, 21075 Hamburg, GERMANY
Attachment:
signature.asc
Description: PGP signature