[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#826665: marked as done (libdebian-installer: libd-i EFI detection can pass while efibootmgr's/efivar's will fail)

Your message dated Mon, 13 Jun 2016 07:34:00 +0000
with message-id <E1bCMNk-0003bG-US@franck.debian.org>
and subject line Bug#826665: fixed in libdebian-installer 0.106
has caused the Debian Bug report #826665,
regarding libdebian-installer: libd-i EFI detection can pass while efibootmgr's/efivar's will fail
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org

826665: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=826665
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message ---
Package: libdebian-installer
Version: 0.102
Severity: normal
Tags: patch
User: ubuntu-devel@lists.ubuntu.com
Usertags: origin-ubuntu yakkety ubuntu-patch

Dear Maintainer,

EFI detection in libd-i can in some cases pass while efibootmgr will fail to
set BootEntry due to efivar's checks actually looking for efivars or vars
instead of just the existence of /sys/firmware/efi.

In Ubuntu; I'm applying the following patch to libdebian-installer's detection

  * src/system/efi.c: validate the presence of efivars *or* vars under
    /sys/firmware/efi to decide whether we should show the system as running
    in EFI mode; either of these paths is required for efibootmgr to set a
    BootEntry at the end of installation.

Admittedly, this can still fail if for some reason efivars or vars are present
but empty, but this isn't any different than for /sys/firmware/efi itself.

/sys/firmware/efi/vars should mostly always be around, as it appears to come
straight from the kernel; /sys/firmware/efi/efivars is typically to be mounted
by the init system (this happens at least in systemd src/core/mount-setup.c).

In Ubuntu this is bug:

Thanks for considering the patch.

-- System Information:
Debian Release: stretch/sid
  APT prefers yakkety
  APT policy: (500, 'yakkety'), (99, 'yakkety-proposed')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.4.0-23-generic (SMP w/4 CPU cores)
Locale: LANG=fr_CA.UTF-8, LC_CTYPE=fr_CA.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
diff -Nru libdebian-installer-0.102ubuntu1/src/system/efi.c libdebian-installer-0.102ubuntu2/src/system/efi.c
--- libdebian-installer-0.102ubuntu1/src/system/efi.c	2015-12-23 19:24:26.000000000 -0500
+++ libdebian-installer-0.102ubuntu2/src/system/efi.c	2016-06-03 21:22:39.000000000 -0400
@@ -26,8 +26,9 @@
  * exists */
 int di_system_is_efi(void)
-	int ret = access("/sys/firmware/efi", R_OK);
-	if (ret == 0)
+	int efivars_access = access("/sys/firmware/efi/efivars", R_OK);
+	int vars_access = access("/sys/firmware/efi/vars", R_OK);
+	if (efivars_access == 0 || vars_access == 0)
 		/* Have we been told to ignore EFI in partman-efi? */
 		ret = access("/var/lib/partman/ignore_uefi", R_OK);

--- End Message ---
--- Begin Message ---
Source: libdebian-installer
Source-Version: 0.106

We believe that the bug you reported is fixed in the latest version of
libdebian-installer, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 826665@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
Christian Perrier <bubulle@debian.org> (supplier of updated libdebian-installer package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)

Hash: SHA256

Format: 1.8
Date: Sun, 12 Jun 2016 09:06:30 +0200
Source: libdebian-installer
Binary: libdebian-installer4 libdebian-installer4-dev libdebian-installer4-udeb libdebian-installer-extra4 libdebian-installer-extra4-udeb
Architecture: source i386
Version: 0.106
Distribution: unstable
Urgency: medium
Maintainer: Debian Install System Team <debian-boot@lists.debian.org>
Changed-By: Christian Perrier <bubulle@debian.org>
 libdebian-installer-extra4 - Library of some extra debian-installer functions
 libdebian-installer-extra4-udeb - Library of some extra debian-installer functions (udeb)
 libdebian-installer4 - Library of common debian-installer functions
 libdebian-installer4-dev - Library of common debian-installer functions
 libdebian-installer4-udeb - Library of common debian-installer functions (udeb)
Closes: 826665
 libdebian-installer (0.106) unstable; urgency=medium
   [ Steve McIntyre ]
   * armhf: Add EFI detection.
   [ Mathieu Trudel-Lapierre ]
   * validate the presence of efivars *or* vars under /sys/firmware/efi to
     decide whether we should show the system as running in EFI mode;
     either of these paths is required for efibootmgr to set a BootEntry at
     the end of installation. Closes: #826665
 3cf5b4520f79953569b1c27e70cb322138abed7d 2200 libdebian-installer_0.106.dsc
 d3c7a91964061d5b88d2ab403e72251b47691768 271392 libdebian-installer_0.106.tar.xz
 7dc67d41c6a712b6b0c2d6d621544e84dee2f0df 6016 libdebian-installer-extra4-dbgsym_0.106_i386.deb
 f368d3123f46ec6700152de4a61de181b8eff103 3794 libdebian-installer-extra4-udeb_0.106_i386.udeb
 6566d13616100ff206852609885a4819c7e4164e 15888 libdebian-installer-extra4_0.106_i386.deb
 c95e38205c11ab756d2d310cc7b961951f454b91 45248 libdebian-installer4-dbgsym_0.106_i386.deb
 43a1f95411801a644ce350d56e0e228c3fbc7b20 172160 libdebian-installer4-dev_0.106_i386.deb
 7c5b322ce5c2f7cca0348228639b160c189caa9c 19674 libdebian-installer4-udeb_0.106_i386.udeb
 fb0858559ca2418fa9896d786834380f8c18a3b1 31898 libdebian-installer4_0.106_i386.deb
 dfb9dc8080d4a9473c2db0d533671293252348bbf8091e2fdb9a8c4b55138769 2200 libdebian-installer_0.106.dsc
 becc39e93cfa66c23314349f6e953f23df5333b16a1040c0b57dd96bfea060f9 271392 libdebian-installer_0.106.tar.xz
 d3553f95f7e430cd887dbea0e850b643f4d44916e90c398f928905b0b7fc5023 6016 libdebian-installer-extra4-dbgsym_0.106_i386.deb
 885fdee92168eafa31d0f9391ad0edf343be5f59af7c267c43277bcbc99fc79e 3794 libdebian-installer-extra4-udeb_0.106_i386.udeb
 75fd5c0eed154046e3ea8c5ea137b6a50d5a1408468aaae0798fd94e75d9f844 15888 libdebian-installer-extra4_0.106_i386.deb
 ac480b144b2b8ba963f4a685638c518c8a753010a662cb2c00379ad999de7dac 45248 libdebian-installer4-dbgsym_0.106_i386.deb
 f162638e45c9c4f9053ed85ee15cc0ed2865ed5d1820406841bbae1f10b906a4 172160 libdebian-installer4-dev_0.106_i386.deb
 5a81b020efefc28e4bc39e6cba4c90c80ce581e6cdaae46a03bda74f165f69ba 19674 libdebian-installer4-udeb_0.106_i386.udeb
 253cb897bfcb5673096c33f32b5d4b7ed61ec58f32eecdaa1763a6da2c145b6e 31898 libdebian-installer4_0.106_i386.deb
 0e9efad30b1b92247129549f67dd7995 2200 libs optional libdebian-installer_0.106.dsc
 bf021cda287996b221228176f96cb761 271392 libs optional libdebian-installer_0.106.tar.xz
 3d7838891c14ac1f7e5985d1f599c407 6016 debug extra libdebian-installer-extra4-dbgsym_0.106_i386.deb
 10bb6db28f1038f95d7b8ebbe38fda59 3794 debian-installer optional libdebian-installer-extra4-udeb_0.106_i386.udeb
 a26bc58a6ee41f35af1f12d8048b2a49 15888 libs optional libdebian-installer-extra4_0.106_i386.deb
 711264d6cc2244cbfa657c4fa05dd9f7 45248 debug extra libdebian-installer4-dbgsym_0.106_i386.deb
 925d44d95610fefcbcfab7ac5058a45c 172160 libdevel optional libdebian-installer4-dev_0.106_i386.deb
 7f2f1476637236b60f02e4d1d8b01cca 19674 debian-installer optional libdebian-installer4-udeb_0.106_i386.udeb
 c05337e0789e0c147da54cac5516adb6 31898 libs optional libdebian-installer4_0.106_i386.deb

Version: GnuPG v1


--- End Message ---

Reply to: