Hi again, Didier 'OdyX' Raboud <odyx@debian.org> (2016-04-22): > Le vendredi, 22 avril 2016, 20.18:23 Cyril Brulebois a écrit : > > This seems to be fixed in git master (bfd32f1eb3). Seeing variables > > there, and checking what happened in the previous commit (7842e76a6d), > > I'm not sure I get what's done there. Why do we need to be able to > > override all those variables? > > MIRROR is really useful when building this package. That one, right. > DISTRIBUTION & KFREEBSD_KERNEL_MAJOR are convenient for upload tests, > but are not really mandatory. I don't really see why one would want to override DISTRIBUTION or VERSION. The former is set depending on the branch you're working in (master or stable branches), and I don't see the point of overriding VERSION (just set what you want in debian/changelog). I don't expect KFREEBSD_KERNEL_MAJOR to change much either… Anyway, those don't really hurt, that was just surprising. Since that's clearly not stable material, that'll stay in master only. > > Another question: any reason why MAJOR_VERSION hasn't been made > > overridable along with the others? > > Because the packages as listed in debian/control contain this > MAJOR_VERSION in the binary package name. Changing the MAJOR_VERSION > implies regenerating debian/control, and a tour through NEW. OK. > > Also, changelog entries explaining commits would be nice. > > Aww, sorry. These are artifacts of my usual gbp-dch workflow. OK. Will you push a changelog update when time permits? KiBi.
Attachment:
signature.asc
Description: Digital signature