[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#815912: marked as done (dasd: detect if a DASD is already configured)

Your message dated Sat, 05 Mar 2016 10:49:59 +0000
with message-id <E1ac9mZ-0005Kx-3z@franck.debian.org>
and subject line Bug#815912: fixed in s390-dasd 0.0.35
has caused the Debian Bug report #815912,
regarding dasd: detect if a DASD is already configured
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org

815912: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=815912
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message ---
Package: s390-dasd
Version: 0.0.34
Severity: normal
Tags: d-i patch

If you have configured one ore more DASDs, the s390-dasd shows
them as "(configured)".  If you then leave the module, for example,
with "Finish", and re-enter the module again, the DASDs show up as
"online" again.

The patch below enhances the detect_channels_driver() function
to check if a configuration file exists, that means, if DASDs
are already online and configured.

Kind regards,
>From ba645de637b74de9a58e4296dae0f4bd6a785c07 Mon Sep 17 00:00:00 2001
From: Hendrik Brueckner <brueckner@linux.vnet.ibm.com>
Date: Mon, 15 Feb 2016 17:44:29 +0100
Subject: [PATCH 4/4] dasd: detect if a DASD is already configured

If the s390-dasd module is started twice, already configured DASDs
appear as "online".  Enhance the detect_channels_driver() function
to check if a configuration file exists, that means, if DASDs are
already online and configured.

Signed-off-by: Hendrik Brueckner <brueckner@linux.vnet.ibm.com>
Reviewed-by: Viktor Mihajlovski <mihajlov@linux.vnet.ibm.com>
 dasd-config.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/dasd-config.c b/dasd-config.c
index 6194da7..e085534 100644
--- a/dasd-config.c
+++ b/dasd-config.c
@@ -1,6 +1,7 @@
 #include <ctype.h>
 #include <errno.h>
 #include <fcntl.h>
+#include <limits.h>
 #include <stdio.h>
 #include <stdlib.h>
 #include <string.h>
@@ -111,6 +112,7 @@ static enum state_wanted setup ()
 static enum state_wanted detect_channels_driver (struct sysfs_driver *driver, int type)
+	char path[PATH_MAX];
 	struct dlist *devices;
 	struct sysfs_device *device;
@@ -141,6 +143,10 @@ static enum state_wanted detect_channels_driver (struct sysfs_driver *driver, in
 		if (strtol (attr_online->value, NULL, 10) > 0)
 			current->online = true;
+		/* Check if the current DASD is already configured */
+		snprintf (path, sizeof (path), SYSCONFIG_DIR "config-ccw-%s", current->name);
+		current->configured = !access (path, F_OK);
 		di_tree_insert (channels, current, current);

--- End Message ---
--- Begin Message ---
Source: s390-dasd
Source-Version: 0.0.35

We believe that the bug you reported is fixed in the latest version of
s390-dasd, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 815912@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
Christian Perrier <bubulle@debian.org> (supplier of updated s390-dasd package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)

Hash: SHA256

Format: 1.8
Date: Sat, 05 Mar 2016 09:01:18 +0100
Source: s390-dasd
Binary: s390-dasd
Architecture: source
Version: 0.0.35
Distribution: unstable
Urgency: low
Maintainer: Debian Install System Team <debian-boot@lists.debian.org>
Changed-By: Christian Perrier <bubulle@debian.org>
 s390-dasd  - Configure DASD (udeb)
Closes: 815912 815918
 s390-dasd (0.0.35) unstable; urgency=low
   * Team upload
   [ Hendrik Brueckner ]
   * dasdfmt: detect format status and improve handling (Closes: #815918)
     - report user error if disk is in use
     - detect and properly handle already formatted DASDs
     - correct and improve <Go back> handling
   * Detect if a DASD is already configured. (Closes: #815912)
   [ Updated translations ]
   * French (fr.po) by Christian Perrier
   * Japanese (ja.po) by Kenshi Muto
   * Portuguese (Brazil) (pt_BR.po) by Adriano Rafael Gomes
   * Portuguese (pt.po) by Miguel Figueiredo
 75e9152122d594ced27f95d0cbffb5c3c42504e2 1707 s390-dasd_0.0.35.dsc
 642afe251aa6de8a3280bade747730065569cf04 58356 s390-dasd_0.0.35.tar.xz
 57389c37f56e732a5104f7076f8a16ce9b4e94138841f2713f9546e44419f4b5 1707 s390-dasd_0.0.35.dsc
 39f8d0dd24e540ff3610250069978f83dc1596f153ef44eabe90eac7f976cc9d 58356 s390-dasd_0.0.35.tar.xz
 557da7cbb3a03e7a484b1e5db2773c2f 1707 debian-installer standard s390-dasd_0.0.35.dsc
 3bdec7bc6b93fcd737b80e8555b705e6 58356 debian-installer standard s390-dasd_0.0.35.tar.xz

Version: GnuPG v1


--- End Message ---

Reply to: