[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#813023: marked as done (flash-kernel: quoting error with bootargs in generic U-Boot boot script)

Your message dated Sun, 21 Feb 2016 11:59:35 +0000
with message-id <1456055975.15441.80.camel@debian.org>
and subject line Re: Bug#813023: flash-kernel: quoting error with bootargs in generic U-Boot boot script
has caused the Debian Bug report #813023,
regarding flash-kernel: quoting error with bootargs in generic U-Boot boot script
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
813023: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=813023
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: flash-kernel
Version: 3.56
Tag: patch

Hi!

There's a small quoting mistake in the generic U-Boot script. It
probably hasn't been noticed so far because the default
LINUX_KERNEL_CMDLINE doesn't contain spaces. See the attached patch.

While, I am at it, I wonder if it would not make more sense to
reverse the order when setting that variable so it reads:

    setenv bootargs "@@LINUX_KERNEL_CMDLINE@@ ${bootargs}"

That way, it's possible to override the default command line by doing
something like:

    setenv bootargs console=ttyAMA0,115200
    boot

-- 
Lunar                                .''`. 
lunar@debian.org                    : :Ⓐ  :  # apt-get install anarchism
                                    `. `'` 
                                      `-   

From 8d87ea9e4adcc48e4bffa0ff3a378fc3e417afe4 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?J=C3=A9r=C3=A9my=20Bobbio?= <lunar@debian.org>
Date: Thu, 28 Jan 2016 16:14:28 +0100
Subject: [PATCH] Properly quote LINUX_KERNEL_CMDLINE in U-Boot generic boot
 script

Otherwise we get an error as soon as LINUX_KERNEL_CMDLINE contains spaces.
---
 bootscript/all/bootscr.uboot-generic | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/bootscript/all/bootscr.uboot-generic b/bootscript/all/bootscr.uboot-generic
index c318be5..1c3f129 100644
--- a/bootscript/all/bootscr.uboot-generic
+++ b/bootscript/all/bootscr.uboot-generic
@@ -25,7 +25,7 @@ if test -n "${console}"; then
   setenv bootargs "${bootargs} console=${console}"
 fi
 
-setenv bootargs ${bootargs} @@LINUX_KERNEL_CMDLINE@@
+setenv bootargs "${bootargs} @@LINUX_KERNEL_CMDLINE@@"
 @@UBOOT_ENV_EXTRA@@
 
 if test -z "${fk_kvers}"; then
-- 
2.1.4

Attachment: signature.asc
Description: Digital signature


--- End Message ---
--- Begin Message --- 
On Sat, 2016-02-20 at 17:46 +0000, Ben Hutchings wrote:
> On Sat, 2016-02-20 at 18:25 +0100, Jérémy Bobbio wrote:
> > Ian Campbell:
> > > So I'm afraid I'm still not clear exactly what issue you are
> seeing.
> > > 
> > > Please can you post:
> > > 
> > >  * the contents of your /boot/cmdline.txt
> > >  * the contents of the flash kernel db entry you have added for the
> > >    RPi2
> > >  * the resulting generated boot.scr.
> > >  * a full serial console log booting with that boot.scr
> > 
> > Sorry Ian, but I don't remember the exact details. That box is now in
> > production and I'd rather not take the risk to break it before next
> > month.
> > 
> > Feel free to just ditch that bug report. It's moot for the RPi2 until we
> > have a compatible kernel in Debian anyway.
> 
> I think we do...

I think I'll still close this bug report for now.

Eventually I hope someone will file a bug with the correct stanza to
add to flash-kernel's db and if there are still quoting issues at that
time we can figure out what to do about that then.

Thanks guys,
Ian.

--- End Message ---
Reply to: