[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#813033: marked as done (qeth: ask for relative OSA port number)



Your message dated Fri, 29 Jan 2016 03:51:23 +0000
with message-id <E1aP05j-00024H-QD@franck.debian.org>
and subject line Bug#813033: fixed in s390-netdevice 0.0.39
has caused the Debian Bug report #813033,
regarding qeth: ask for relative OSA port number
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
813033: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=813033
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message ---
Package: s390-netdevice
Version: 0.0.38
Severity: important
Tags: d-i patch

Hi,

below is another patch for the s390-netdevice regarding qeth device
configuration.  Some cards require the specification of the relative
port number on the OSA card.   Ths s390-netdevice has template and
state information for this attribute but lacks the actual
implementation.

The attached patch will let the user specify the relative OSA port
number.  The setting can also be preseeded if necessary.


Thanks and kind regards,
  Hendrik
>From 439483cd533d865d96a8c8119b221e9a56f25925 Mon Sep 17 00:00:00 2001
From: Hendrik Brueckner <brueckner@linux.vnet.ibm.com>
Date: Fri, 20 Nov 2015 12:57:36 +0100
Subject: [PATCH 2/4] qeth: ask for the relative OSA port number

Let the user specify the port number because this is required for
particular OSA cards.

Reported-by: Elisabeth Puritscher <elisabeth.puritscher@de.ibm.com>
Signed-off-by: Hendrik Brueckner <brueckner@linux.vnet.ibm.com>
---
 netdevice.c | 20 ++++++++++++++++++--
 1 file changed, 18 insertions(+), 2 deletions(-)

diff --git a/netdevice.c b/netdevice.c
index 6ddece9..6905c2d 100644
--- a/netdevice.c
+++ b/netdevice.c
@@ -638,6 +638,22 @@ static enum state_wanted write_sysfs (void)
 			syslog (LOG_ERR, "Can't write ccwgroup device attribute layer2");
 			return WANT_ERROR;
 		}
+
+		/* Set the relative port number.
+		 * Valid port numbers are 0 (default) or 1
+		 */
+		if (device_current->qeth.port)
+		{
+			attr = sysfs_get_device_attr (device, "portno");
+			if (attr)
+			{
+				if (sysfs_write_attribute (attr, "1", 1) < 0)
+				{
+					syslog (LOG_ERR, "Could not write device attribute portno");
+					return WANT_ERROR;
+				}
+			}
+		}
 	}
 
 	attr = sysfs_get_device_attr (device, "online");
@@ -703,6 +719,7 @@ static enum state_wanted write_qeth (void)
 
 	if (device_current->qeth.layer2)
 		fprintf (config, "QETH_OPTIONS=(layer2)\n");
+	fprintf (config, "QETH_PORTNO=%d", device_current->qeth.port);
 
 	fclose (config);
 
@@ -837,8 +854,7 @@ int main (int argc __attribute__ ((unused)), char *argv[] __attribute__ ((unused
 						state = GET_QETH_LAYER2;
 						break;
 					case GET_QETH_LAYER2:
-						/* state = GET_QETH_PORT; */
-						state = CONFIRM_QETH;
+						state = GET_QETH_PORT;
 						break;
 					case GET_QETH_PORT:
 						state = CONFIRM_QETH;
-- 
2.7.0.rc3


--- End Message ---
--- Begin Message ---
Source: s390-netdevice
Source-Version: 0.0.39

We believe that the bug you reported is fixed in the latest version of
s390-netdevice, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 813033@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Philipp Kern <pkern@debian.org> (supplier of updated s390-netdevice package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Fri, 29 Jan 2016 04:00:47 +0100
Source: s390-netdevice
Binary: s390-netdevice
Architecture: source s390x
Version: 0.0.39
Distribution: unstable
Urgency: medium
Maintainer: Debian Install System Team <debian-boot@lists.debian.org>
Changed-By: Philipp Kern <pkern@debian.org>
Description:
 s390-netdevice - Configure network hardware (udeb)
Closes: 813030 813033
Changes:
 s390-netdevice (0.0.39) unstable; urgency=medium
 .
   [ Hendrik Brueckner ]
   * qeth: ask for the relative OSA port number (Closes: #813033)
   * qeth: remove portname (Closes: #813030)
Checksums-Sha1:
 cec271c48ee616d60d3a43ca10caaac751f7b266 1442 s390-netdevice_0.0.39.dsc
 4521db85ca24268d5d23d174a109c6bb39a98493 108620 s390-netdevice_0.0.39.tar.xz
 ffc1297bba920eb2fda883c249c124dfc81125f6 83100 s390-netdevice_0.0.39_s390x.udeb
Checksums-Sha256:
 93eff04fc868f744b1f73a77cc912c94d31b466c6d193c0f4c64b572a06f56fe 1442 s390-netdevice_0.0.39.dsc
 5a055a2e9428c08bb21a236bdbc94cd386d56d577567c90766bf7d2c0b91efb5 108620 s390-netdevice_0.0.39.tar.xz
 50dad2309aaa3a3be3ac47b54f52201d597b34f69b9f64c28590d1227299a07f 83100 s390-netdevice_0.0.39_s390x.udeb
Files:
 a115de04060c897197c4cd01eea01ce4 1442 debian-installer standard s390-netdevice_0.0.39.dsc
 582cf779d88d704600a547e369839f87 108620 debian-installer standard s390-netdevice_0.0.39.tar.xz
 f7532a4a786f413ba41f05f43abee045 83100 debian-installer standard s390-netdevice_0.0.39_s390x.udeb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQEcBAEBCAAGBQJWqt7TAAoJEERuJUU10Fbspk4H/RT9RVAXd8+KSxuii+Gvg8Qi
myZUjkMZK2A/PonCtxmh/r9qzJLCEOAWK477hynUj1DeWGsrw0k+QQi6MvdD/q2A
3ZgsAPxPK4rVMlEh4fsBwTBw0cb4K2JKLbt0aqbEpmllKHwEN+bl1kF75yH4UwTa
CxkruBcpu8PJ6XS/qOmyw+DUBvlpemNlRFXMfoUsPEIxK0n2LnbBGIh9FivFltZs
UYxMMUdXDUMklziQ3ytuui9O/Fxyqk5AkZjBfKMpeYfGF/M0zDTsUHivo5pQnP4D
eix3Brv8VY7wzw7zNuxt5PQ1rJQ2lWDNyDHd8Ngm8Ee0Q/B78eQ37uCgmx1CeW4=
=piYW
-----END PGP SIGNATURE-----

--- End Message ---

Reply to: