[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#806341: marked as done (zipl-installer: Using standard device names can result in a non-bootable system)

Your message dated Wed, 06 Jan 2016 10:32:00 +0000
with message-id <E1aGlNo-0001Cg-NY@franck.debian.org>
and subject line Bug#806341: fixed in zipl-installer 0.0.29
has caused the Debian Bug report #806341,
regarding zipl-installer: Using standard device names can result in a non-bootable system
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
806341: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=806341
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: zipl-installer
Version: 0.0.28
Severity: normal
Tags: d-i patch

Dear Maintainer,

Currently, the root= statement used by zipl will contain a standard device
name like /dev/dasda1.
This will only work reliable if only one disk device is used while booting.
If more than one disk device is discovered the name of the device used by
the root filesystem might change resulting in a not found root filesystem.
I suggest to use the filesystem UUID of the root filesystem where possible,
similar to what's used in /etc/fstab.

-- System Information:
Debian Release: stretch/sid
  APT prefers testing
  APT policy: (500, 'testing')
Architecture: amd64 (x86_64)

Kernel: Linux 4.2.0-1-s390x (SMP w/1 CPU core)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

>From a29dbc2bc4548b39c1dc340bf2c02f70724b72a1 Mon Sep 17 00:00:00 2001
From: Viktor Mihajlovski <mihajlov@linux.vnet.ibm.com>
Date: Thu, 26 Nov 2015 17:45:51 +0100
Subject: [PATCH] postinst: use UUID for root device parameter where possible

The approach to use a default device node like /dev/dasdn for
the root= kernel parameter is unsafe if more than one disk
device is brought online during IPL as the device node identifier
could change.

A safer way is to construct the root= parameter to match the
/etc/fstab entry for the root fs.

Here we use block-attr --uuid to find out the root filesystem's
UUID and pass this via kernel parameter. If no UUID is found fall
back to the mapdevfs-determined device.

If the root file system is on a logical volume, it is currently not
possible to mount it by UUID in the initrd. Therefore fall back to
the device mapper path which is unique (enough).

Signed-off-by: Viktor Mihajlovski <mihajlov@linux.vnet.ibm.com>
Signed-off-by: Hendrik Brueckner <brueckner@linux.vnet.ibm.com>
---
 debian/zipl-installer.postinst | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/debian/zipl-installer.postinst b/debian/zipl-installer.postinst
index c70ab6f..c3b7f31 100755
--- a/debian/zipl-installer.postinst
+++ b/debian/zipl-installer.postinst
@@ -19,6 +19,13 @@ rootfs="$(mapdevfs $rootfs_devfs)"
 log "Root filesystem on ${rootfs} (${rootfs_devfs})"
 
 PARAMETER="root=${rootfs}"
+if rootlvm="$(lvm lvdisplay -C -ovg_name,lv_name --noheadings ${rootfs})"
+then
+    info "Root filesystem is on LV (${rootlvm})"
+elif rootuuid="$(block-attr --uuid ${rootfs})"
+    info "Root filesystem UUID is ${rootuuid}"
+    PARAMETER="root=UUID=${rootuuid}"
+fi
 
 cat > /target/etc/zipl.conf << EOF
 [defaultboot]
-- 
1.9.1

--- End Message ---
--- Begin Message --- 
Source: zipl-installer
Source-Version: 0.0.29

We believe that the bug you reported is fixed in the latest version of
zipl-installer, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 806341@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Philipp Kern <pkern@debian.org> (supplier of updated zipl-installer package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Wed, 06 Jan 2016 10:30:46 +0100
Source: zipl-installer
Binary: zipl-installer
Architecture: source s390x
Version: 0.0.29
Distribution: unstable
Urgency: medium
Maintainer: Debian Install System Team <debian-boot@lists.debian.org>
Changed-By: Philipp Kern <pkern@debian.org>
Description:
 zipl-installer - Make DASD bootable (udeb)
Closes: 806341
Changes:
 zipl-installer (0.0.29) unstable; urgency=medium
 .
   [ Viktor Mihajlovski ]
   * postinst: use UUID for root device parameter where possible
     (Closes: #806341)
Checksums-Sha1:
 180550aed91c5c64494575da42352dedb8a6357c 1344 zipl-installer_0.0.29.dsc
 2032507cb13ab623247e071ecc36b233a474186b 21752 zipl-installer_0.0.29.tar.xz
 fc6f457161603a4edbe0e6d6274455e13689b6ac 4632 zipl-installer_0.0.29_s390x.udeb
Checksums-Sha256:
 bf62fdaa5edfede5784d8bcf762ccb7227eccea3293d94e0fbc1ae476f4c8d06 1344 zipl-installer_0.0.29.dsc
 a559e97f2e6dad9965ef88a6c33a2e41b9e22d170f7c3697a8e278426574153a 21752 zipl-installer_0.0.29.tar.xz
 7f64572a107642c0da80a22d876b1f07ed05247812d2ae1f184fd90fef6c35a0 4632 zipl-installer_0.0.29_s390x.udeb
Files:
 af889eeb4253ba33bd6dd836768952d2 1344 debian-installer standard zipl-installer_0.0.29.dsc
 ae5126b6bfa6576dd6cef67fae922ddd 21752 debian-installer standard zipl-installer_0.0.29.tar.xz
 56bf88d2fcae85110de924ebe83444fd 4632 debian-installer standard zipl-installer_0.0.29_s390x.udeb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQEcBAEBCAAGBQJWjN+6AAoJEERuJUU10Fbs0BgH/2WWGnzV1RTqpEZgYinqrRO8
8LAWb1VRLWvdJLlO6YtD70MRa+4d535+AMujy5Z1vrIhkaoPyXzDvEnBrpM92BsV
DrjFA0rJdIGKNzJsv0zY280V3Gbb29Uf8t4CFzII+Nv9KZ2Zz5wGApnu/662IlIL
b7ytYgaSN9mnAcAr0NEnF79H+lSKpjFo+5uSczGHQ9s4CgURWWVGI8A/cLlloT77
7nrJlubsFdeD+PS4ukFG60q/BbtWKcmPFAEAv5n/H5TMFQ74rX/rtSiycvMsNnQW
W6TzdNwVaWamptRNV2WdhwLIzlkIGmkFuA+3nQ/ozGQQCMpNK7smQyhFuD9MqnA=
=2few
-----END PGP SIGNATURE-----

--- End Message ---
Reply to: