Hi,
Hendrik Brueckner <brueckner@linux.vnet.ibm.com> (2015-12-15):
> Control: tags -1 + patch
>
> Attach a patch to check if the DASD is already online because
> trying to set a DASD online twice results in an error causing
> the s390-dasd module to fail.
I'm no DASD expert but this looks fine from afar. Was that successfully
tested and confirmed to work? Trying to figure out whether to make it
migrate to testing ASAP for inclusion in the next d-i release.
Mraw,
KiBi.
> Thanks and kind regards,
> Hendrik
> diff -Nru s390-dasd-0.0.32/dasd-config.c s390-dasd-0.0.33/dasd-config.c
> --- s390-dasd-0.0.32/dasd-config.c 2015-12-14 11:42:56.000000000 +0100
> +++ s390-dasd-0.0.33/dasd-config.c 2015-12-14 11:43:07.000000000 +0100
> @@ -244,6 +244,9 @@
> struct sysfs_device *device;
> struct sysfs_attribute *attr;
>
> + if (channel_current->online)
> + return WANT_NEXT;
> +
> device = sysfs_open_device ("ccw", channel_current->name);
> if (!device) {
> di_error("s390-dasd: could not open device %s",
> diff -Nru s390-dasd-0.0.32/debian/changelog s390-dasd-0.0.33/debian/changelog
> --- s390-dasd-0.0.32/debian/changelog 2015-12-14 11:42:56.000000000 +0100
> +++ s390-dasd-0.0.33/debian/changelog 2015-12-15 09:47:15.000000000 +0100
> @@ -1,3 +1,12 @@
> +s390-dasd (0.0.33) UNRELEASED; urgency=medium
> +
> + * Setting a DASD online if it is already online, results in EINVAL
> + and the s390-dasd module exists immediately.
> + Check if an DASD is already online and, if so, advance to the next
> + configuration step. (Closes: #808007)
> +
> + -- Hendrik Brueckner <brueckner@linux.vnet.ibm.com> Mon, 14 Dec 2015 11:41:55 +0100
> +
> s390-dasd (0.0.32) unstable; urgency=medium
>
> * If no channel is found, exit cleanly. This allows s390-dasd to step
Attachment:
signature.asc
Description: Digital signature