[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#799361: marked as done (preseed: always sets preseed_unspecified_at_boot (since fix for #759290))



Your message dated Wed, 23 Sep 2015 10:28:40 +0000
with message-id <E1ZehI0-0006gu-Bo@franck.debian.org>
and subject line Bug#799361: fixed in preseed 1.68
has caused the Debian Bug report #799361,
regarding preseed: always sets preseed_unspecified_at_boot (since fix for #759290)
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
799361: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=799361
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message ---
Package: preseed
Severity: minor

Since #759290 is archived, I'll send this again as a new report.

Regarding this commit:

  http://anonscm.debian.org/cgit/d-i/preseed.git/commit/?id=f2e7bae02caec5a66e25d5af7aab90eb7648deca

The attempted fix here mangles the logic of the if statement.

The &&'s after the db_get's are about checking that the setting is set,
you cannot invert those and get a useful result.

I'm now unsure how to fix this without reintroducing #759290.

One could restore the if statement, with an empty then, but I think that
the real bug is that we don't have a test for the DHCP provided preseed,
so the real fix would be to add such a test to the if as it was before.

In case you're wondering why one should care, the result is that the
touch /var/run/preseed_unspecified_at_boot is always run now, which
means that preseed scripts that use that to determine what to do if the
user didn't specify a preseed at boot, but rather did so when prompted
during the install, will do the wrong thing.

This feature is useful if one wants to have a demo preseed setup that
can notice that the user was a newbie, and will then drop into a more
interactive tutorial, for example.

Cheers, Phil.

--- End Message ---
--- Begin Message ---
Source: preseed
Source-Version: 1.68

We believe that the bug you reported is fixed in the latest version of
preseed, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 799361@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Christian Perrier <bubulle@debian.org> (supplier of updated preseed package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Tue, 22 Sep 2015 07:01:34 +0200
Source: preseed
Binary: preseed-common network-preseed file-preseed initrd-preseed env-preseed
Architecture: source all
Version: 1.68
Distribution: unstable
Urgency: medium
Maintainer: Debian Install System Team <debian-boot@lists.debian.org>
Changed-By: Christian Perrier <bubulle@debian.org>
Description:
 env-preseed - debconf preseeding via environment variables (udeb)
 file-preseed - load debconf preseed file (udeb)
 initrd-preseed - load debconf preseed file from /preseed.cfg on the initrd (udeb)
 network-preseed - download debconf preseed file (udeb)
 preseed-common - common files for preseeding (udeb)
Closes: 799361
Changes:
 preseed (1.68) unstable; urgency=medium
 .
   [ Philip Hands ]
   * rectify preseed_unspecified_at_boot test, that was broken in 1.65.
     Closes: #799361
Checksums-Sha1:
 967f2e137795c40b18d1f4d32a507e63a6d2a5e9 1883 preseed_1.68.dsc
 9aa2eb2943d1656162461efa2da324bc7ccee89a 74924 preseed_1.68.tar.xz
 5c0940925aec0c397d98b37baea4108973c168dc 1764 env-preseed_1.68_all.udeb
 3e079a0f3b945d5671b4e5f199fed63571b7d5b8 4168 file-preseed_1.68_all.udeb
 fd0e9b1f23dd59dee04db0b8a293839867b2bcb2 890 initrd-preseed_1.68_all.udeb
 691d4e965fe01db4de0eeec6940cc7e68f979ce9 30884 network-preseed_1.68_all.udeb
 8a91a5a040e0ee666aa10888c2c9d46d3c723c21 21584 preseed-common_1.68_all.udeb
Checksums-Sha256:
 49e247b871784aa4720fddb5304742269247d4e48cc8a1f7e74d50caaae21f4c 1883 preseed_1.68.dsc
 6943110e9c17c4ef87f3c8a7903c7c4c30bd18a82fc56c54cda9ae892d305197 74924 preseed_1.68.tar.xz
 f9b007563bddeb134fdf733f8b02f179ecb76045a822962bdcbb71246845ddf3 1764 env-preseed_1.68_all.udeb
 3fb19bd2a4a794b4f0692760d1a3f39d592e6c15d788288050190b415bc05214 4168 file-preseed_1.68_all.udeb
 fca79fe92ea383d14e5b2dd33c7d177e1bd789e6282a5a3c306c01672c12eec1 890 initrd-preseed_1.68_all.udeb
 47ce525bb9c12219881c18a8065a954522944a2ce36fba72d14e457fff7089cb 30884 network-preseed_1.68_all.udeb
 72f2a0b9321985c258bb4cd8afae2205777be61e89276f77d7ae6b01d5f46390 21584 preseed-common_1.68_all.udeb
Files:
 5b01da1a8f3a8fc8df1ff56562885e63 1883 debian-installer optional preseed_1.68.dsc
 0ea62d2cbf13c68183ef71590b20eca6 74924 debian-installer optional preseed_1.68.tar.xz
 b1596952bc86c7ae9b48939ca390d114 1764 debian-installer extra env-preseed_1.68_all.udeb
 6f26e1e26b30ac735df9e63d41b24dba 4168 debian-installer optional file-preseed_1.68_all.udeb
 cf43eb5a5e5b9edfae85278081e07c7e 890 debian-installer extra initrd-preseed_1.68_all.udeb
 509c7052eee7cdf10a19a7b2bd69c4c4 30884 debian-installer standard network-preseed_1.68_all.udeb
 d1c94ac96250fc549496499b6474bc33 21584 debian-installer standard preseed-common_1.68_all.udeb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBCAAGBQJWAi4qAAoJEIcvcCxNbiWo6hMP/RjyGw5jljvvTSG4xK/Ugldb
x/S6L9EimuZYRK930vPIsmZ8z6S5/jjp+c+828YB4ItNid3x3DGDbq7MM9C1aamk
y/55RCClWa0yqAoHaAPS4xfjhkeGRUPmXTeKgnWy1ZmMcNQwBrmixLCWIBn81wpe
0VMk+2UVxV8IqbPIApWECpOElGiFUwMNpiKX3HLYA3DNeTRC8bqSSjKFWuZowW0m
lPj2ZyQ07XNac4eWid6jD7kzodoHfSr5SPmBx8QPYIQ/flCUUQ8EFcdjB5LTY/AS
yEFBkS+ijwrs5uZAn658jD8dHEncUsV2VpOzzSkk9Hg1KS1JYwskQc6IQXCKFPDq
bHvQhlCNWYC16GfdE8c1mbT6NnlW4qSm1sttPkfkV5F7Z68DIkywLIpi5vqzNszL
OnJV0p0VeDw4WnXC/JVvCdrAYzaLc+wfOX2EIOAAx6nj2oYO9eOt/qxG/KRHLxuH
6ACzO12EKiYTiBSNlXbU/PSN60XmzCBa5SqZKqn4+CYgdeN5bA50US7w3mrDKFee
Sk4aWOicP2B4DnzNboXXoVaW/IHyfMtvOaK/KPa4WcBfoWdJnTuusQreG5S9kzZr
7fm0SFWxSdZOj8Es8FbpslqHufeoxPAhnxCrKbG3OgzGjria8wESScIUQcADTPWP
whCETuKp55OlMuHrOUSf
=y6Qn
-----END PGP SIGNATURE-----

--- End Message ---

Reply to: