Tsung-Han Lin <tsung-han.lin@canonical.com> writes: > Hi, > > I've just made a patch to solve the emmc partition issue during > installation. > Could you kindly help review this? > Thank you. > > BugLink: https://bugs.launchpad.net/ubuntu/+source/partman-base/+bug/1456443 > Index: partman-base-172ubuntu1/init.d/parted > =================================================================== > --- partman-base-172ubuntu1.orig/init.d/parted 2014-02-05 22:50:17.000000000 +0800 > +++ partman-base-172ubuntu1/init.d/parted 2015-05-19 12:08:13.878119958 +0800 > @@ -93,6 +93,11 @@ > continue > fi > > + # Skip emmc devices' boot0, boot1 and rpmb partitions > + if echo $device | grep -q -e '/dev/mmcblk0\(rpmb\|boot\)'; then > + continue > + fi I presume this produces the same effect: case "$device" in /dev/mmcblk0rpmb | /dev/mmcblk0boot? ) continue ;; esac (which has the benefit of needing no forks) BTW How sure are we that mmcblk0 and mmcblk1 are going to always turn up that way round? I'd think that the presence of the rpmb/boot0/1 suffix is the real key, in which case one could do: case "$device" in /dev/mmcblk?rpmb | /dev/mmcblk?boot? ) continue ;; esac Cheers, Phil. -- |)| Philip Hands [+44 (0)20 8530 9560] HANDS.COM Ltd. |-| http://www.hands.com/ http://ftp.uk.debian.org/ |(| Hugo-Klemm-Strasse 34, 21075 Hamburg, GERMANY
Attachment:
signature.asc
Description: PGP signature