[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#764677: marked as done (installation-guide: Please use "---" not "--" on installer's kernel command line)

Your message dated Fri, 23 Jan 2015 11:40:47 +0100
with message-id <20150123104047.GA10796@type.bordeaux.inria.fr>
and subject line Re: Bug#762007: Kernel command line handling change breaks d-i user-params functionality
has caused the Debian Bug report #764677,
regarding installation-guide: Please use "---" not "--" on installer's kernel command line
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
764677: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=764677
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: debian-installer-utils
X-Debbugs-CC: debian-kernel@lists.debian.org

(CCing debian-kernel just FYI, since I don't think this can/should be
fixed with a kernel change, likewise filing against
debian-installer-utils and not the kernel even though a kernel change
introduced the breakage)

A recent change to the kernel[0] (from v3.15 onwards) has changed the
way the kernel handles its command line, such that it now ignores
anything passed after a "--" marker. This has broken d-i's own use of
that marker which was to separate options intended for the installer
only (before the marker) from those which are intended to be both
consumed by the d-i kernel and propagated to the final installation
(after the marker, returned by the user-params utility).

It used to be that you could do:
        vmlinuz some/preseed=value -- console=ttyFOO
which would have the dual affect of having the kernel console (and hence
installer UI) run on ttyFOO and also, via grub-installer's use of
user-params, propagate the console=ttyFOO into the final grub config
(similarly for other bootloaders).

With the kernel change this no longer works -- the kernel doesn't put
its console on ttyFOO since it stops parsing at the --. So you get
silence on boot.

To get the old behaviour you need
        vmlinuz some/preseed=value console=ttyFOO -- console=ttyFOO
which is pretty tedious.

Just using
        vmlinuz some/preseed=value console=ttyFOO
doesn't propagate the console=ttyFOO to the installed system.

Since the kernel change was related to the "systemd abusing kernel
cmdline" debacle I'm not overly keen on raising this upstream and I
don't think that changing the kernel in a way which diverges from
upstream would not be the right approach here.

I don't know how widely used/documented/Supported this ability was, but
I thought e.g. the pxe and isolinux cfgs made use of it.

Not sure what we can do about this. Perhaps choose another separator
("=="?) and make user-params support both?

Ian.

[0] https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=51e158c12aca3c9ac63988611a97c05109b14dc9

--- End Message ---
--- Begin Message --- 
Version: 20141230

Ian Campbell, le Fri 10 Oct 2014 08:20:41 +0100, a écrit :
> > As well as this fix I think we need to investigate which of these need
> > fixing too (i.e. with s/--/---/ in appropriate places):
> >       * Installation guide
> 
> I've assigned clones of this bug to these.

I had actually fixed it in the latest upload, closing the bug.

Samuel

--- End Message ---
Reply to: