Bug#806713: disk-detect/multipath: update checks for changed mpath alias names
Package: disk-detect
Version: 1.114
Severity: normal
Tags: d-i patch
Dear maintainers,
An update in the multipath-tools, [1], changed the naming scheme for
mpath aliases created when the user friendly names option is specified.
The alias naming changed from mpath0 to mpatha replacing the numeric
digits with alphabetic letters. The patch below updates the disk-detect.sh
to correctly detect multipath devices with the new naming scheme.
On the people/cyphermox/mpath-detect branch in the d-i/hw-detect
repository, there is already a patch for the same problem. I could not
find a bug report for it. So that's why I am opening this one to keep
this problem in mind.
It would be great if you could help me to understand the practice on how
such problem fixes becomes integrated.
Apart from the disk-detect package, the partman-multipath package is
also affected by mpath naming change. I will open a separate bug report
and attach a patch to solve the naming there.
Many thanks in advance!
[1]
https://anonscm.debian.org/cgit/pkg-lvm/multipath-tools.git/commit/?id=81716d6fe5ccf220e320e168391817810645c3b4
Kind regards,
Hendrik
>From 8ecaf3a49c1b7d0f765895ebc8156efadcc0ca23 Mon Sep 17 00:00:00 2001
From: Hendrik Brueckner <brueckner@linux.vnet.ibm.com>
Date: Fri, 27 Nov 2015 11:17:57 +0100
Subject: [PATCH] disk-detect/multipath: update checks for changed mpath alias names
The alias naming scheme for user friendly names has been changed
from mpath[0-9] to mpath[a-z] a while ago. Update the disk-detect.sh
script to use the new alias naming scheme to correctly detect multipath
devices.
See also
https://anonscm.debian.org/cgit/pkg-lvm/multipath-tools.git/commit/?id=81716d6fe5ccf220e320e168391817810645c3b4
Signed-off-by: Hendrik Brueckner <brueckner@linux.vnet.ibm.com>
---
disk-detect.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/disk-detect.sh b/disk-detect.sh
index c3b77cc..8498f4f 100755
--- a/disk-detect.sh
+++ b/disk-detect.sh
@@ -113,7 +113,7 @@ EOF
fi
log-output -t disk-detect /sbin/multipath -v$MP_VERBOSE
- if multipath -l 2>/dev/null | grep -q '^mpath[0-9]\+ '; then
+ if multipath -l 2>/dev/null | grep -q '^mpath[a-z]\+ '; then
return 0
else
return 1
--
2.6.2
Reply to: