[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Broken EFI grub.cfg on stretch images



Hello,

Cyril Brulebois, on Thu 26 Nov 2015 01:31:19 +0100, wrote:
> Steve McIntyre <steve@einval.com> (2015-11-26):
> > KiBi/Didier: I've now noticed the there's a slight issue with the
> > menus we have at the moment. Not sure if it's an artifact of the
> > multi-arch setup or not, but in the menus we're now getting two
> > different versions of the installer with speech both veing shown with
> > the exact same label text and the same shortcut:
> > 
> > label installspk
> >         menu label Install with ^speech synthesis
> >         kernel /install.amd/vmlinuz
> >         append vga=788 initrd=/install.amd/initrd.gz speakup.synth=soft --- quiet 
> > 
> > label installspk
> >         menu label Install with ^speech synthesis
> >         kernel /install.amd/vmlinuz
> >         append vga=788 initrd=/install.amd/gtk/initrd.gz speakup.synth=soft --- quiet 
> > 
> > and this is showing up in the grub menus I'm generating too. We should
> > probably just pick one that we want?
> 
> Wild guess, side effect of the following commit (src:debian-installer)?
> | commit d14db6ad4079b3e4d996f67ffd36292b18e6b15b
> | Author: Samuel Thibault <samuel.thibault@ens-lyon.org>
> | Date:   Tue Sep 15 01:31:14 2015 +0200
> | 
> |     Restore actually-used non-gtk speech synthesis entries
> |     
> |         - Otherwise netboot/gtk/mini.iso (which is gtk only) does not contain the
> |           speech entry.
> |         - Avoid including them on non-gtk netboot image, though.
> 
> https://anonscm.debian.org/cgit/d-i/debian-installer.git/commit/?id=d14db6ad4079b3e4d996f67ffd36292b18e6b15b
> 
> (Adding youpi to the loop accordingly.)

Thanks for the Cc.  That looks like the trigger, yes, because it
restores spk.cfg.  I hadn't noticed that ./util/syslinux-cfgs lists
*all* .cfg files when used for cdrom targets.  I have now blacklisted
spk.cfg there.  I agree that this is less than ideal, but this is a
consequence of the choice of putting the initrd of gtk-only netboot
images at the root instead of gtk/ Perhaps that could be changed?

Samuel


Reply to: