[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#735169: marked as done (os-prober cannot work with the latest upstream blkid (util-linux-2.24))

Your message dated Thu, 08 Oct 2015 12:36:42 +0000
with message-id <E1ZkAR8-0002Dn-Me@franck.debian.org>
and subject line Bug#735169: fixed in os-prober 1.68
has caused the Debian Bug report #735169,
regarding os-prober cannot work with the latest upstream blkid (util-linux-2.24)
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
735169: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=735169
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: os-prober
Version: 1.63
Severity: wishlist
Tags: upstream

Dear Maintainer,

The new blkid in util-linux-2.24 is able to recognize the extend
partition, but os-prober relies on the return value "2" (exit_not_found)
of blkid to skip processing the extend partition.

Then, with the new version of util-linux, os-prober will try
to mount the extend partition with FS types found in the system,
which is dangerous.

e.g.,

# fdisk -l
....
Device    Boot     Start       End    Blocks  Id System
/dev/sda1 *           63 252847034 126423486   7 HPFS/NTFS/exFAT
/dev/sda2      252847035 625137344 186145155   5 Extended
/dev/sda5      252847098 253425374    289138+ 83 Linux
/dev/sda6      385254828 482913899  48829536  83 Linux
....


blkid 2.24-2
---
# blkid /dev/sda2
/dev/sda2: PTTYPE="dos" PARTUUID="28b48ca1-02"
# echo $?
0

# blkid -o value -s TYPE /dev/sda2  # no output
# echo $?
0


blkid 2.20.0
---
# blkid /dev/sda2  # no output
# echo $?
2
# blkid -o value -s TYPE /dev/sda2  # no output
# echo $?
2


Affected os-prober code:
---
File: /usr/lib/os-probes/50mounted-tests
-
8   types="$(fs_type "$partition")" || types=NOT-DETECTED
9   if [ "$types" = NOT-DETECTED ]; then
10      debug "$1 type not recognised; skipping"
11      exit 0


With the old blkid (util-linux-2.20),
os-prober will just skip here when handling /dev/sda2,
but with the new version of blkid,
os-prober will go on and try to mount /dev/sda2 with
FS types found in the system, which causes lots of errors,
even kernel calltrace when trying xfs.


This is not a problem now because util-linux-2.20 is currently
used, but when someday util-linux-2.24 is introduced in,
this would be a serious problem.


-- System Information:
Debian Release: jessie/sid
  APT prefers testing-updates
  APT policy: (500, 'testing-updates'), (500, 'testing')
Architecture: amd64 (x86_64)

Kernel: Linux 3.12-1-amd64 (SMP w/1 CPU core)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages os-prober depends on:
ii  libc6  2.17-97

os-prober recommends no packages.

os-prober suggests no packages.

-- no debconf information

--- End Message ---
--- Begin Message --- 
Source: os-prober
Source-Version: 1.68

We believe that the bug you reported is fixed in the latest version of
os-prober, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 735169@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Cyril Brulebois <kibi@debian.org> (supplier of updated os-prober package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.8
Date: Thu, 08 Oct 2015 14:26:16 +0200
Source: os-prober
Binary: os-prober-udeb os-prober
Architecture: source
Version: 1.68
Distribution: unstable
Urgency: medium
Maintainer: Debian Install System Team <debian-boot@lists.debian.org>
Changed-By: Cyril Brulebois <kibi@debian.org>
Description:
 os-prober  - utility to detect other OSes on a set of drives
 os-prober-udeb - utility to detect other OSes on a set of drives (udeb)
Closes: 735169 801278
Changes:
 os-prober (1.68) unstable; urgency=medium
 .
   * Adjust extended dos partition support for blkid/util-linux 2.24+,
     thanks to Andreas Henriksson (Closes: #735169).
   * Add support for Windows 10 (otherwise reported as Windows Recovery
     Environment). Thanks, Philipp Wolfer! (Closes: #801278).
Checksums-Sha1:
 191b164d90a1e6f2b445862a4705f1a981714f73 1734 os-prober_1.68.dsc
 42b0fbf12647e09296c6771ffb4ff150ec068d5b 25336 os-prober_1.68.tar.xz
Checksums-Sha256:
 31d133792e3e6e7217097ede27d3987bfe8c136b1a5347d29216038c71a002b4 1734 os-prober_1.68.dsc
 ad0b98c3e59239bff94e8f03bb618c21043c5314a7d00726d53f84add8478804 25336 os-prober_1.68.tar.xz
Files:
 403f2732653ccd7b0049b1e2d4f4c80f 1734 debian-installer optional os-prober_1.68.dsc
 11e9794cc4bfd77092c76d9d96a2035b 25336 debian-installer optional os-prober_1.68.tar.xz

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBAgAGBQJWFmEyAAoJEP+RSvDCs1UgmIIQAJL4TunQmmXXXFkKoQtBFbvz
cylGLPb0ZJXFgyed4lh6wMPon6aAqZCH3JIITsAFP+CIUaJVmGr5z0SQpo84Mffi
gTSQkkp4+b1X4w3KOM41yyzfmQISBWuJB3Uii5RUpy1VPDj1ZsQcjJompYol0Caz
gV6F21b0a4TgeB4Y3e1aa2PGN0wkWyYuAVx3BAdLl1oNkAJrCcIOQl3EVHKjlJmp
4KLpfPKTL24RO4E6K2EKbXYLlaTg1Ag26qPG75UGI1KjQ0sOmOA49DarvSsMtkqj
9hwGHd1jB8jvYvRn4GaNg8ATMPDs0I+sH+crkGMvvBC5Glm9dwYjNbsr1CZATS+u
MAVIMy733mcMniASfY+x/xuSj2L0hR1CtXW/UkE/ZtLSOTLU2Za0h3EgZFl9NP3f
NvBqak0KDCxIU6ymt2lGJG7NHW92y0ppjBpKS6y2rFOw++29vPxAEEygL8cX4Duc
zgYmt6zeZ3C9qnMRVkbgVwN01nXCdwknWxs1Ia4qLUfghQzy4wGo5GC59KoXFF24
ADokFrHxpRZPLc4Tfy6/7E4C7pL0mIDUKLAjh27XvllwtytbB9FZF5KKDhkCtC1r
nYvJShQAt3kqTOM4GmzXmPBT3wQBkdtyBQzrgJIcAlp48HEpf7VcuhTXw1orpV5Z
y9keXE7cxev+3c0vF32X
=l1jP
-----END PGP SIGNATURE-----

--- End Message ---
Reply to: