Control: tag -1 pending Control: severity -1 important Hi, Andreas Henriksson <andreas@fatal.se> (2014-07-12): > Control: tags -1 + patch > > Hello! > > I'm working on an updated util-linux package (v2.24.2) and was pointed > to this os-prober bug report. > > In my limited testing I haven't been able to reproduce any problems > here with os-prober and util-linux 2.24.2. > > I can confirm though that the behaviour of running blkid against > an extended dos partition has changed. In the new version information > is correctly reported for those instead of just erroring out. > > The old blkid version (2.20.1) returns error code 2 when running > against an extended dos partition. > > $ sudo blkid -V > blkid from util-linux 2.24.2 (libblkid 2.24.0, 24-Apr-2014) > > $ sudo blkid -o export /dev/sda2 > DEVNAME=/dev/sda2 > PTUUID=dd6e951b > PTTYPE=dos > PARTUUID=000ae69f-02 > > $ sudo blkid /dev/sda2 > /dev/sda2: PTUUID="dd6e951b" PTTYPE="dos" PARTUUID="000ae69f-02" > > > I'm attaching a patch that should hopefully help. It tries to make the > executed codepath similar to what it was by adding an extra check on the > case where value of TYPE is "" and then exits 0 if it looks like an > extended dos partition. > > Any feedback would be greatly appreciated. Thanks for the patch, and sorry for the delay. I've pushed it to git for now (it'll likely be uploaded by Christian when he has time). I'm adjusting the severity as well as I don't think wishlist is right for this kind of bug. A cherry-pick to stable might be a good idea at some point, I suppose (jessie has 2.25.2). Mraw, KiBi.
Attachment:
signature.asc
Description: Digital signature