[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#794403: flash-kernel: command "update-initramfs -uk <kver>" result in boot images in false version



Package: flash-kernel
Version: 3.45
Severity: normal
Tags: patch

Dear Maintainer,

Hook script "initramfs-hook/flash-kernel" will be called when update-initramfs
is invoked. However flash-kernel only build the latest kernel version it find,
rather than the specific version passing from update-initramfs.

For example, after running "update-initramfs -uk <kver>", the <kver> is
successfully passed to "initramfs-hook/flash-kernel", and then "flash-kernel"
script, but "flash-kernel" script simply ignore that version, except adding
a "--force" flag, which is why this patch is here.

I also checked the log for initramfs-hook/flash-kernel, as commit 7bacb9 the
kernel version was actually not passed to "flash-kernel" script, but from
commit e05fc9, this has been changed, which I think it means the flash-kernel
script need to honor what kernel version update-initramfs is working on.

Thanks and looking forward to your comments.

Cheers,
Roger

-- System Information:
Debian Release: 8.1
  APT prefers stable
  APT policy: (990, 'stable'), (500, 'stable-updates'), (500, 'unstable'), (1, 'experimental')
Architecture: armel (armv5tel)

Kernel: Linux 4.0.0-2-kirkwood
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: sysvinit (via /sbin/init)

Versions of packages flash-kernel depends on:
ii  debconf [debconf-2.0]  1.5.56
ii  devio                  1.2-1+b1
ii  initramfs-tools        0.120
ii  linux-base             3.5
ii  ucf                    3.0030

Versions of packages flash-kernel recommends:
ii  u-boot-tools  2014.10+dfsg1-5

flash-kernel suggests no packages.
>From 1af8343110d71fc4ba6da6e346a384cb910a2b05 Mon Sep 17 00:00:00 2001
From: Roger Shimizu <rogershimizu@gmail.com>
Date: Mon, 3 Aug 2015 00:38:53 +0900
Subject: [PATCH] initramfs-hook: let flash-kernel build the correct version of
 boot images

Currently, flash-kernel script simply ignores the kernel version passing
from update-initramfs command, but just pick up a latest kernel to build
boot images.

This patch fixes that, by adding a "--force" flag to flash-kernel script.

Signed-off-by: Roger Shimizu <rogershimizu@gmail.com>
---
 initramfs-hook/flash-kernel | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/initramfs-hook/flash-kernel b/initramfs-hook/flash-kernel
index 21da5e6..92236b7 100755
--- a/initramfs-hook/flash-kernel
+++ b/initramfs-hook/flash-kernel
@@ -11,5 +11,4 @@ abi="$1"
 # ignored
 _initrd="$2"
 
-exec flash-kernel "$abi"
-
+exec flash-kernel --force "$abi"
-- 
2.1.4


Reply to: