On Wed, 20 May 2015 02:35:52 +0200 Philippe Coval wrote: > I managed to prevent this trouble by adding an extra test is os-prober We discussed this on #debian-boot: <rzr> hi , would anyone like to help fixing a critical bug ? https://bugs.debian.org/784709 <rzr> I want to push a patch upstream <pabs> I think a better option might be to change return 0 to return 1 in fs_type? <pabs> and or possibly add support for blkid <pabs> oh, it is already there <pabs> rzr: do you have an extended partition handy? <rzr> yea pabs <rzr> but I upgraded kernel since <pabs> what is the output of this? blkid -o value -s TYPE /dev/sdX ; echo $? <rzr> 2 <pabs> hmmm, so that should trigger the types=NOT-DETECTED part already? <rzr> suspicious <rzr> I was thinking the same <rzr> well It's a bit late let's get feedback from bug reporter <rzr> pabs, thx anyway I'll stay around <pabs> indeed, could you send a mail CCing the submitter and asking them for this? blkid -o value -s TYPE /dev/sdb4 ; echo $? <rzr> older kernel return 0 <rzr> double checking current one <pabs> you mean older blkid? <rzr> no kernel 3.5.0-030500rc5-generic <rzr> from u <rzr> :) <pabs> but blkid is the thing that returns the value 2? <rzr> but stay calm i run debian <rzr> oh wait <rzr> it return 0 in all cases <rzr> I had mistyped sd4 for sda4 <rzr> so I could return err in that fs_type fuct if nullstring <pabs> blkid returns 0 or fs_type returns 0? <rzr> blkid <pabs> does it return the right thing for the other partitions? <rzr> yea <pabs> hmm <rzr> http://paste.debian.net/180700/ (copied below) <rzr> may the bug be in blkid then ? <pabs> not sure where it is TBH <pabs> which version of util-linux <rzr> Version: 2.25.2-6 <rzr> 1 version behind upstream <rzr> well i have to go <rzr> I'll email if no feedback in a couple of days <pabs> rzr: what about sudo file -s /dev/sda4 ? <rzr> /dev/sda4: DOS/MBR boot sector; partition 1 : ID=0x83, start-CHS (0x3ff,47,57), end-CHS (0x3ff,254,63), startsector 2, 47565448 sectors; partition 2 : ID=0x5, start-CHS (0x3ff,0,1), end-CHS (0x3ff,254,63), startsector 47565450, 32772600 sectors --- rzr is now known as rZr <rZr> see ya <pabs> later for i in $(seq 1 5 ) ; do echo "" ; blkid -o value -s TYPE /dev/sda$i ; echo "$i=$?" ; done vfat 1=0 vfat 2=0 swap 3=0 4=0 ext3 5=0 -- bye, pabs https://wiki.debian.org/PaulWise
Attachment:
signature.asc
Description: This is a digitally signed message part