[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#783019: kirkwood network console images ask to choose ethernet device



Package: oldsys-preseed
Version: 3.15
Severity: grave
Tags: patch

Doing a test install of jessie on my TS-419 I get asked (via the serial)
for a serial port and a ssh password. I happen to have a serial port but
these devices mostly do not and are supposed to be headless.

I'm using the images from
http://ftp.uk.debian.org/debian/dists/jessie/main/installer-armel/20150418/images/kirkwood/network-console/qnap/ts-41x/

>From the logs there is no sign of oldsys-preseed running. Poking around
in the shell I see:
        ~ # sh -x /usr/bin/oldsys-preseed 
        + set -e
        + . /usr/lib/oldsys-preseed/functions
        + NONINTERACTIVE=yes
        + FILE=/preseed.cfg
        + archdetect
        + + sed s/Hardware\s*:\s*//
        grep ^Hardware /proc/cpuinfo
        + machine=QNAP TS-41x
        + cat /proc/device-tree/model
        + dt_model=
        ~ # 

IOW due to set -e it exits early on systems
where /proc/device-tree/model does not exist, since the cat fails.

By commenting out that one line things seem to progress in a way which
looks promising (i.e. much more spew than above). I think the most
plausible solution would be:

diff --git a/oldsys-preseed b/oldsys-preseed
index f60196f..4cd7138 100755
--- a/oldsys-preseed
+++ b/oldsys-preseed
@@ -115,7 +115,11 @@ case "`archdetect`" in
        arm*/orion5x | arm*/kirkwood)
                machine=$(grep "^Hardware" /proc/cpuinfo | sed 's/Hardware\s*:\s*//')
                # /proc/device-tree may not exist on all architectures
-               dt_model=$(cat /proc/device-tree/model 2>/dev/null)
+               if [ -e /proc/device-tree/model ] ; then
+                   dt_model=$(cat /proc/device-tree/model 2>/dev/null)
+               else
+                   dt_model="UNKNOWN"
+               fi
                if echo "$machine" | grep -q "^Buffalo/Revogear Kurobox Pro"; then
                        check_file /proc/mtd
                        rootfs=$(get_mtdblock "rootfs")

I'll build an image and test that shortly.

Severity grave because d-i is mostly useless on qnap hardware (and
headless orion or kirkwood generally) with this issue, at least for
non-DT systems, which I think is still most of them in Jessie.

Ian.


Reply to: