Cyril Brulebois <kibi@debian.org> (2015-03-04): > Ben Hutchings <ben@decadent.org.uk> (2015-03-03): > > Yes, that's right. The problem is that we now detect missing firmware > > by scraping the kernel log, and we still pick up old ones after > > installing firmware and poking the driver. > > > > I think we could solve this by noting the timestamp at the bottom of the > > kernel log every time we scan it, then only checking lines after that on > > the next scan. > > I think that's an idea I mentioned in a previous bug report, yes. I'll > try and see if I can implement & verify this before RC2. I've now implemented that in the following commit: http://anonscm.debian.org/cgit/d-i/hw-detect.git/commit/?id=1fda53e722375a3ea580f465f7e716d9a3b5da36 Pasting the commit message here for reference: | Make sure not to look at past lines in dmesg (Closes: #779546). | | If user supplies firmware on a USB stick, missing firmware detection | happens again, and if dmesg hasn't received enough lines to get rid of | old “firmware: failed to load” entries, the situation looks like it | hasn't improved. | | To avoid such a loop, note the timestamp of the last dmesg line after | having scanned for such lines, and in case missing firmware detection | runs again, use this timestamp to filter out previous lines in case it's | still present in the new dmesg output; or use the whole dmesg output if | that timestamp has vanished. | | Tested successfully on bare metal with iwlwifi, in 3 cases: | - USB stick with firmware in place before boot: seamless. | - USB stick with firmware plugged after the “search on removable media” | prompt: OK. | - USB stick with firmware not plugged after the first “search on | removable media” prompt, but on the second try (so that there's a | search that doesn't find anything): OK. | | Tested-by: Cyril Brulebois <kibi@debian.org> | Signed-off-by: Cyril Brulebois <kibi@debian.org> And as mentioned on IRC… certainly not the prettiest code ever, but one of the criterion was “must work and be built before 19:52”. Let's see how that works or breaks for others through D-I Jessie RC3… Mraw, KiBi.
Attachment:
signature.asc
Description: Digital signature