[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#778773: [PATCH] Likely fix for crash



Control: tag -1 jessie sid

Cyril Brulebois <kibi@debian.org> (2015-03-04):
> And your hypothesis seems totally plausible, let's look at
> d56c74f310b02af4f81e5f5a5ba65b55fdbdc34e[1]:
> | Adapt parted_server code to handle new GNU Parted swap filesystem handling.
> | 
> | r59025
> 
>  1. http://anonscm.debian.org/cgit/d-i/partman-base.git/commit/?id=d56c74f310b02af4f81e5f5a5ba65b55fdbdc34e
> 
> I could imagine how tempting it would be to copy-paste between
> partition_info() and command_get_file_system(). The former deals with
> part->[…] stuff, while the latter deals with fstype.
> 
> I'm very tempted to get the fix uploaded ASAP so that people can toy
> around, even if I don't do any testing myself. I don't see how it could
> possibly become worse than the current state of affairs.

So in the end I've been able to reproduce this issue with the unpatched
partman-base in testing at the time, and to see it go away with the
patched one in sid; the updated package got therefore merged into jessie
in time for D-I Jessie RC2 (even if I failed to mention this in the
release announce, woops).

In the meanwhile I haven't been able to reproduce this issue with wheezy
even if the wrong code in partman-base was already there. Looking at the
diff between parted 2.3 and 3.2, there have been some fstype vs. fs_type
assignments getting changed so this likely explains why the partman-base
isn't exposed there. I'm therefore adding the “if it ain’t broke, don’t
fix it” tags accordingly.

Mraw,
KiBi.

Attachment: signature.asc
Description: Digital signature


Reply to: