[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#761815: fixed in partman-target 94



On Wed, Mar 18, 2015 at 11:03:26PM +0100, Cyril Brulebois wrote:
>Hi,
>
>Christian Perrier <bubulle@debian.org> (2015-01-26):
>>  partman-target (94) unstable; urgency=medium
>>  .
>>    [ Steve McIntyre ]
>>    * Don't add entries for random USB media to /etc/fstab, they're not
>>      useful. Closes: #761815
>
>I'd like to know how that was tested. Using libvirt, importing mini.iso
>as a USB hard drive (appearing as /dev/sda during installation),
>installing on to an IDE disc (appearing as /dev/sdb), leads to the use
>of partman-target 94 per syslog, and yet /etc/fstab ends up containing
>a /media/usb0 entry:
>| # /etc/fstab: static file system information.
>| #
>| # Use 'blkid' to print the universally unique identifier for a
>| # device; this may be used with UUID= as a more robust way to name devices
>| # that works even if disks are added and removed. See fstab(5).
>| #
>| # <file system> <mount point>   <type>  <options>       <dump>  <pass>
>| # / was on /dev/sdb1 during installation
>| UUID=a38aa670-fb4c-4482-8af1-42f34b41ebdb /               ext4    errors=remount-ro 0       1
>| # swap was on /dev/sdb5 during installation
>| UUID=cd9c4a52-91c4-4b44-8d34-c880357974b9 none            swap    sw              0       0
>| /dev/sda1       /media/usb0     auto    rw,user,noauto  0       0

Maybe we've got a misunderstanding here. The change is only expected
to stop *other* USB devices from showing up in /etc/fstab. If you're
installing using /dev/sda as a mini.iso / HD_MEDIA, then that will
still be added for now.

Whether that's *also* right or wrong I'm not 100% sure, but that's not
what I was expecting to change. What happens if you add some other USB
devices in your test?

-- 
Steve McIntyre, Cambridge, UK.                                steve@einval.com
"When C++ is your hammer, everything looks like a thumb." -- Steven M. Haflich


Reply to: