[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#776488: marked as done (regression: arm map_hardware[] not NULL terminated)

Your message dated Wed, 28 Jan 2015 18:18:38 +0000
with message-id <E1YGXCI-0005IE-Ih@franck.debian.org>
and subject line Bug#776488: fixed in libdebian-installer 0.99
has caused the Debian Bug report #776488,
regarding regression: arm map_hardware[] not NULL terminated
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
776488: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=776488
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: libdebian-installer4
Version: 0.98
Severity: serious
Tags: d-i patch

The map_hardware[] table in src/system/subarch-arm-linux.c is no longer NULL
terminated. I believe this could lead to a segfault on armel/armhf platforms,
resulting in a failed install.

This bug was introduced back in version 0.92. The end of the table was trimmed,
and accidentally took the NULL terminator with it:
  http://anonscm.debian.org/cgit/d-i/libdebian-installer.git/commit/?id=3a7209e49fa5cfe8c4e4122325405022031a8afc
  
DISCLAIMER: I haven't actually observed a crash, I just discovered this while
reviewing source. But it does seem like a potential time-bomb we should fix
pre-release. Here's the obvious patch:

diff --git a/src/system/subarch-arm-linux.c b/src/system/subarch-arm-linux.c
index 590576a..3fc5e2a 100644
--- a/src/system/subarch-arm-linux.c
+++ b/src/system/subarch-arm-linux.c
@@ -103,6 +103,7 @@ static struct map map_hardware[] = {
     { "OMAP3 Beagle Board", "omap" },
     { "OMAP4 Panda Board", "omap" },
     { "ARM-Versatile Express", "vexpress" },
+    { NULL, NULL }
 };
 
 static int read_dt_model(char *entry, int entry_len)

-- System Information:
Debian Release: 8.0
  APT prefers unstable
  APT policy: (500, 'unstable'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386, arm64

Kernel: Linux 3.16.0-4-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages libdebian-installer4 depends on:
ii  libc6              2.19-13
ii  multiarch-support  2.19-13

libdebian-installer4 recommends no packages.

libdebian-installer4 suggests no packages.

-- no debconf information

--- End Message ---
--- Begin Message --- 
Source: libdebian-installer
Source-Version: 0.99

We believe that the bug you reported is fixed in the latest version of
libdebian-installer, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 776488@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
dann frazier <dannf@debian.org> (supplier of updated libdebian-installer package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.8
Date: Wed, 28 Jan 2015 10:51:22 -0700
Source: libdebian-installer
Binary: libdebian-installer4 libdebian-installer4-dev libdebian-installer4-udeb libdebian-installer-extra4 libdebian-installer-extra4-udeb
Architecture: source
Version: 0.99
Distribution: unstable
Urgency: medium
Maintainer: Debian Install System Team <debian-boot@lists.debian.org>
Changed-By: dann frazier <dannf@debian.org>
Description:
 libdebian-installer-extra4 - Library of some extra debian-installer functions
 libdebian-installer-extra4-udeb - Library of some extra debian-installer functions (udeb)
 libdebian-installer4 - Library of common debian-installer functions
 libdebian-installer4-dev - Library of common debian-installer functions
 libdebian-installer4-udeb - Library of common debian-installer functions (udeb)
Closes: 776488
Changes:
 libdebian-installer (0.99) unstable; urgency=medium
 .
   * Replace NULL terminator for the arm map_hardware table, accidentally
     dropped in 0.92 (Closes: #776488).
Checksums-Sha1:
 4f340691db221d600f0f4ea83532bc831eb24595 2170 libdebian-installer_0.99.dsc
 c45f606d22e8dec736a8690c86ba503055330331 69932 libdebian-installer_0.99.tar.xz
Checksums-Sha256:
 2cc33156e17dd2341123e00e44d44c349a7892660cbdaeeb1df35cd894858c45 2170 libdebian-installer_0.99.dsc
 84ab9826f3d1d20c6a44d456c65dbbd4725e1c31602811a79ad505c675b9494f 69932 libdebian-installer_0.99.tar.xz
Files:
 08b081a1aed020d44cba0a00b6a8ebae 2170 libs optional libdebian-installer_0.99.dsc
 693e1a141c92007527ea3235daf51ba1 69932 libs optional libdebian-installer_0.99.tar.xz

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBAgAGBQJUySPjAAoJEBv4PF5U/IZAzPwP/1iegB9tx1fmGZgShuvCsfMH
y6v5hj2Bk/aT/J7TuROHErr3Fp3PqF87Eib2IeBJ4iBG9Azg7hC+nbS6tg6AJS2W
Gtp81F6Rex4bcFt6iGH4nZW2+eIgtEz/rHKUEUyEb2pKmESV4mjfkBjkwMEvGzYw
OcDpAwgFUJ8B1q/eO7ztQancQdRvhQM+3JuzQFFHfAWceyg2Z0Y66NrtGmEcvPO4
SqOmaeVZvl8lpYamLk4Fc3P2nakg9YMUrLR+QC+bLTlEdMA0mXOvGrh7lGpU5GMB
QUQoMDYgzyfGemSKAdpC8aMwGxOOrfw/fR9yp4gO2ff4nixuH1ejk6/BRSd52W9H
bSunNTKQYUC57MPum5FXFDs6AQxpqIIwMcQJ+er4nGAPzE3fgPeP9Xb+n9Kpao38
5y7RCVEj33g5QZeYjgttHajdau/eh02ZlTW+Bc9HGqv3xhqih270W8AcP3WyjiLR
qyPavbzqlopNYa8MPmIFIBxcrx20d3jsTZ2KMqDMrZC9g9UfiMjcT/vhwDpMCOq0
U1ZQYZG1bV67Qx+k0a6eha86cV756t2TzUqIA+Cfe1ZJwA4x/PjW3UTZcz2ueJAQ
URs9n2kaSLucBkd0jwjBY6+w4nf/OJMTaGbq0kBvlIwCp/LVeA0IaX46uORjaskV
MYdgxLwCmg+FNQE+/eWj
=V7w8
-----END PGP SIGNATURE-----

--- End Message ---
Reply to: