Bug#775683: marked as done (Selection of potential LVM devices also lists alignment gap artifacts)
Your message dated Mon, 26 Jan 2015 07:33:48 +0000
with message-id <E1YFeBA-00061f-DT@franck.debian.org>
and subject line Bug#775683: fixed in partman-lvm 105
has caused the Debian Bug report #775683,
regarding Selection of potential LVM devices also lists alignment gap artifacts
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)
--
775683: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=775683
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message ---
Package: partman-lvm
Version: 103
Severity: important
Tags: d-i patch
Similar to #775567 for partman-md, partman-lvm can be thrown by small
alignment artifacts and end up confusingly also listing lots of block
devices which are actually too small to be valid.
A simple fix is to simply not show block device objects that are too
small, i.e. less than 4MB in size. Trivial patch included here, and
I'll check this into git shortly as soon as I get a bug number for the
changelog. :-)
diff --git a/lib/lvm-base.sh b/lib/lvm-base.sh
index 656893a..f5bc221 100644
--- a/lib/lvm-base.sh
+++ b/lib/lvm-base.sh
@@ -209,7 +209,7 @@ pv_allowed () {
if [ $lvm = no ]; then
local fs
open_dialog PARTITION_INFO $id
- read_line x1 x2 x3 x4 fs x6 x7
+ read_line x1 x2 size x4 fs x6 x7
close_dialog
if [ "$fs" = free ]; then
# parted can't deal with VALID_FLAGS on free space
@@ -237,6 +237,12 @@ pv_allowed () {
fi
fi
+ # Don't list devices that are too small (less than 4MB),
+ # they're most likely alignment artifacts
+ if [ $size -lt 4194304 ]; then
+ lvm=no
+ fi
+
[ $lvm = yes ]
}
-- System Information:
Debian Release: 7.8
APT prefers stable
APT policy: (500, 'stable'), (500, 'oldstable')
Architecture: amd64 (x86_64)
Foreign Architectures: i386
Kernel: Linux 3.2.0-4-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
--- End Message ---
--- Begin Message ---
Source: partman-lvm
Source-Version: 105
We believe that the bug you reported is fixed in the latest version of
partman-lvm, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to 775683@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Christian Perrier <bubulle@debian.org> (supplier of updated partman-lvm package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Format: 1.8
Date: Mon, 26 Jan 2015 08:15:59 +0100
Source: partman-lvm
Binary: partman-lvm
Architecture: source all
Version: 105
Distribution: unstable
Urgency: medium
Maintainer: Debian Install System Team <debian-boot@lists.debian.org>
Changed-By: Christian Perrier <bubulle@debian.org>
Description:
partman-lvm - Adds support for LVM to partman (udeb)
Closes: 775683
Changes:
partman-lvm (105) unstable; urgency=medium
.
[ Steve McIntyre ]
* Don't list free devices that are too small (less than 4MB). They're
not going to be useful at all, and they're also likely to simply be
alignment artifacts that we can't use anyway. Closes: #775683
Checksums-Sha1:
94038adcfc689578fa2f54ffd6daea61ad568967 1688 partman-lvm_105.dsc
a00498859f5e51ec3267c242923dc3e02901a000 250228 partman-lvm_105.tar.xz
66ddcbadb31e78e3d66f5e7f198714d968a08455 372780 partman-lvm_105_all.udeb
Checksums-Sha256:
8a8973de250a745c07e50256b17ea479e88993609f10037bed01446342c84d29 1688 partman-lvm_105.dsc
8ee42bb032e9b50ab03ad9d6e49b5f61976304f689a792cdb4ea19a82dc3012b 250228 partman-lvm_105.tar.xz
7b3ffe9de70df03702fdffc444b5cc8e6852aaefd7d5db3180a40b09d30784a8 372780 partman-lvm_105_all.udeb
Files:
a2d6636f640ae6b9477f8643d7224cce 1688 debian-installer optional partman-lvm_105.dsc
43fe34cb808912880102fdc9b96eb56a 250228 debian-installer optional partman-lvm_105.tar.xz
011e7556daaebbec4cbbbcff5e4fd159 372780 debian-installer optional partman-lvm_105_all.udeb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)
iQIcBAEBCAAGBQJUxen8AAoJEIcvcCxNbiWorzYP/0a2tT/b1SS+xTrBdXEL8+x/
AR9faGSCWJZsfLfCk1md7JHNuSVWmHKrNeybJMLo/XQNk5g9L6Y94MJfIKtBRD0l
4NlMhafSdqTnHcyS90Bsa9WvxG0K/OSzOiuGfMWLRc9ywZ1zQ0Dzk/tiJAgkdRgo
/Y66raFnPdNpbVO6sQ635burXjvWlkHL0Z2TF2idDx31yfuWcLFDRzrBeMiaEqNA
Fa4BIxiH/tODC4tRbPXbpMtNHcyT06Ss1wVnC4WYjUBPg6T+QVH8Md1Qu0k5HY33
Bl218hg0oWDyySDw3dF0frlgU5I6EGm7SNsRzheFqaLlkbTWuQ3KkLV3CQ5QgIYT
uqvwU5OrjuPrlHaEBQfc8wCnCxgXXziHe329A2MCdHArMKqK0XEQSdYWj611eoM5
GnJuwI8/pw4hx8VKdEFQXIspcXYLjK4kixLommKNGrfYhMQV/eXOT3T2izxpa6dV
ZMEQs5TZoALt6E0sK4Hknx9AMH0NK6ou6Mv6B4pYqXQBV1GHycJL1bMGPOsUxRvy
InCigBG5io3BaxwqZuBmsedaiy/sFb5P4B9BNwURbOsI3u6kKV/a1SCSAy/24qqX
g2quGWK5AYZ5G4dqKvIPotDwFdUGFEZvrd0s5CMrBuDBhlWBMbBGEg9g9QqFVECG
TuLB32Xybgh3aM8CwY7O
=8hhE
-----END PGP SIGNATURE-----
--- End Message ---
Reply to: