On 2015-01-01, Karsten Merker wrote: > +++ b/build/boot/README.concatenateable_images ... > +To create a complete image from the two parts on Linux systems, you can > +use zcat (for .gz images), bzcat (for .bz2 images) or xzcat (for .xz > +images) as follows: > + > + zcat firmware.<board_name>.img.gz partition.img.gz > complete_image.img > + > +respectively > + > + bzcat firmware.<board_name>.img.bz2 partition.img.bz2 > complete_image.img > + > +respectively > + > + xzcat firmware.<board_name>.img.xz partition.img.xz > complete_image.img I'm wondering if one example would be sufficiently explanatory? I'd suggest changing "as follows:" to "for example:" and removing the bzcat/xzcat examples. > --- a/build/config/armhf/hd-media.cfg > +++ b/build/config/armhf/hd-media.cfg ... > +.PHONY: hd-media_images_full > +hd-media_images_full: $(KERNEL) $(INITRD) $(TEMP_DTBS) hd-media_bootscript > + -rm -rf $(TEMP)/hd-media_images_full > + mkdir $(TEMP)/hd-media_images_full ... > +.PHONY: hd-media_images_concatenateable > +hd-media_images_concatenateable: $(KERNEL) $(INITRD) $(TEMP_DTBS) hd-media_bootscript > + -rm -rf $(TEMP)/hd-media_images_concatenateable > + mkdir $(TEMP)/hd-media_images_concatenateable The hd-media_images_full and hd-media_images_concatenateable targets are very similar. Would it make sense to always build the concatenateable images, and then have the hd-media_images_full target generate it's images by simply concatenating the results of the hd-media_images_concatenateable target? That would reduce some code duplication; are there any drawbacks or significant differences in the resulting images? live well, vagrant
Attachment:
signature.asc
Description: PGP signature