Bug#750953: flash-kernel: Add support for SolidRun Cubox-i Dual/Quad.
On Mon, 2014-06-09 at 09:36 -0700, Vagrant Cascadian wrote:
> On Mon, Jun 09, 2014 at 08:39:24AM +0100, Ian Campbell wrote:
> > On Sun, 2014-06-08 at 14:27 -0700, Vagrant Cascadian wrote:
> > > It works with the default u-boot environment in the u-boot package in Jessie.
> > > It requires /etc/default/flash-kernel to define root= in LINUX_KERNEL_CMDLINE,
> >
> > Are you sure about
> > that? /usr/share/initramfs-tools/hooks/flash_kernel_set_root should be
> > setting a fallback root in the initrd, so if the command line doesn't
> > have root= I think things should still work.
>
> As long as / is defined in /etc/fstab...
Ah yes, true.
> > > It only supports booting off of mmc, though in theory booting off of eSATA
> > > might be possible.
> >
> > When that comes homefully we can upgrade in a backwards compatible way.
> > I suppose/home it might be as simple as:
> > if test -z ${device} ; then
> > setenv device mmc
> > fi
> > instead of the unconditional setenv. That assumes that the uboot env
> > would then set $device to scsi, but that seems pretty conventional
> > nowadays.
>
> Need to quote the tested variable:
>
> if test -z "${device}" ; then
> setenv device mmc
> fi
>
> Sounds good to me, though ${partition} would need to have an appropriate value
> set in this case as well, as it currently uses ${mmcdev}:${mmcpart}. Not sure
> how complicated it's worth making it...
I think it is OK as it was, I just wanted to check we weren't painting
ourselves into a corner wrt future changes, I think I'm convinced we are
not.
> Also looks like "Bootloader-Sets-Incorrect-Root: no" can be dropped entirely.
Yes.
Do you have push rights to this repo or would you like me to pickup the
patch?
Ian.
Reply to: