Control: tag -1 patch Joey Hess <joeyh@debian.org> (2004-12-27): > I was suprised to see that the acpi fan and thermal modules were not > loaded on the installed system. This seems to be an oversight in > rootskel, it loads the modules in the installer, but neglects to > register-module them. > > If acpid had been installed, I think it would have taken care of > loading all those modules. And it's needed for the gnome battery > monitor anyway. We need a laptop task! However, I think that even with > that, unconditionally register-moduleing fan and thermal is good from > a belt and suspenders POV. I know close to nothing about module (auto)loading and the like, but if the attached patch can do no harm and can actually help, I'm happy to push it. What do you think? Mraw, KiBi.
From 45fb2aaa5d4e449c89fd3fe61a2c568628c0ec57 Mon Sep 17 00:00:00 2001
From: Cyril Brulebois <kibi@debian.org>
Date: Fri, 28 Feb 2014 23:26:24 +0300
Subject: [PATCH] register-module {acpi,thermal} in addition to modprobe
(Closes: #287412).
---
debian/changelog | 8 ++++++++
src/lib/debian-installer-startup.d/S05acpi-linux-x86 | 2 ++
2 files changed, 10 insertions(+)
diff --git a/debian/changelog b/debian/changelog
index b067778..a336a06 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,11 @@
+rootskel (1.108) UNRELEASED; urgency=medium
+
+ * debian-installer-startup.d/S05acpi-linux-x86: In addition to calling
+ modprobe {acpi,thermal}, register-module them so that the installed
+ system is configured accordingly (Closes: #287412).
+
+ -- Cyril Brulebois <kibi@debian.org> Fri, 28 Feb 2014 23:23:53 +0300
+
rootskel (1.107) unstable; urgency=low
[ Martin Michlmayr ]
diff --git a/src/lib/debian-installer-startup.d/S05acpi-linux-x86 b/src/lib/debian-installer-startup.d/S05acpi-linux-x86
index 3300192..49392be 100644
--- a/src/lib/debian-installer-startup.d/S05acpi-linux-x86
+++ b/src/lib/debian-installer-startup.d/S05acpi-linux-x86
@@ -2,3 +2,5 @@
# overheating.
modprobe fan >/dev/null 2>&1 || true
modprobe thermal >/dev/null 2>&1 || true
+register-module fan
+register-module thermal
--
1.9.0
Attachment:
signature.asc
Description: Digital signature