Re: Bug#772953: Enable several Kconfigs to support OMAP5432 uEVM devboard
On Fri, 2014-12-26 at 18:43 +0800, Chen Baozi wrote:
> On Tue, Dec 23, 2014 at 7:44 PM, Ian Campbell <ijc@debian.org> wrote:
> > On Tue, 2014-12-23 at 16:27 +0800, Chen Baozi wrote:
> >> I have a glance at the kernel’s installer configs and tried the netboot
> >> without any modification. Some work should be done to make debian-installer
> >> support OMAP5 uEVM (e.g., ethernet driver etc).
> >
> > Right, those should be listed in e.g.
> > debian/installer/armhf/modules/armhf-armmp/nic-modules.
> >
> >> By waiting the kernel building with some initial attempted configs added,
> >> just one question to ask. I looked through the
> >> debian/installer/armhf/modules/armhf-armmp/, but it looks like none of
> >> files is about regulator modules. However, according to my previous
> >> experience, missing regulator driver modules is the main reason that
> >> the old debian kernel doesn’t support OMAP5 uEVM. How does debian-installer
> >> deal with this situation (if it does need extra regulator drivers included?)
> >
> > Long term its a bit of an open question what we do wrt modules such as
> > regulators, clocks, pinctrl etc.
> >
> > So far we have been a bit lucky: either such things are so central to
> > the platform that it is acceptable (at least for now) to just build them
> > into the main kernel binary by making them =y (e.g. CONFIG_I2C_S3C2410
> > which is for the main power controller on arndale) or they are closely
> > associated with some particular device and it makes sense to put them in
> > that udeb (e.g. phy-exynos5250-sata in sata-modules, or phy-sun4i-usb in
> > usb-modules).
> >
> > Eventually I expect that we will end up creating separate udebs for
> > these things, but I'm hoping that we can defer that until at least
> > Stretch to avoid needing to mess around with any more new packages for
> > Jessie.
> >
> > If uEVM has some module which either shouldn't be built in or isn't
> > obviously associated with a particular device let us know what it is and
> > we can have a think about how best to approach it.
> >
> > One thing I've played with, and I'm not sure if this is acceptable or
> > not, is to put core drivers which aren't =y into the kernel-image udeb
> > itself. I'm not really sure if that's a good idea, we don't currently do
> > this for anything AFAIK, but it's perhaps an option.
>
> With the attached patch applied, debian installer (tested with network-console)
> can support OMAP5's ethernet driver and external MicroSD card.
>
> Note that I added related regulator & phy entries to files that mainly writes
> the modules which use them, since there is no file dedicated to those
> modules.
Here is what I went with (am build testing now, will push to svn once
done):
commit e05093889458a806352d3e281b2f20db098925fb
Author: Ian Campbell <ijc@debian.org>
Date: Mon Dec 29 14:36:47 2014 +0000
Updates to udebs for OMAP5432 uEVM support.
Based on a patch from Chen Baozi. Added pbias-regulator to mmc-modules and
ohci-omap3, ehci-omap and phy-omap-usb2 to usb-modules (dwc3-omap was already
present).
Enabled CONFIG_REGULATOR_PALMAS and CONFIG_TI_PIPE3 as builtin since they are
used by multiple subsystems.
diff --git a/debian/config/armhf/config.armmp b/debian/config/armhf/config.armmp
index 8781e59..62e512f 100644
--- a/debian/config/armhf/config.armmp
+++ b/debian/config/armhf/config.armmp
@@ -579,7 +579,7 @@ CONFIG_PCI_MVEBU=y
##
CONFIG_OMAP_CONTROL_PHY=m
CONFIG_OMAP_USB2=m
-CONFIG_TI_PIPE3=m
+CONFIG_TI_PIPE3=y
CONFIG_TWL4030_USB=m
CONFIG_PHY_EXYNOS5250_SATA=m
CONFIG_PHY_SUN4I_USB=m
@@ -638,7 +638,7 @@ CONFIG_REGULATOR_TWL4030=y
CONFIG_REGULATOR_VEXPRESS=m
CONFIG_REGULATOR_PBIAS=m
CONFIG_REGULATOR_TI_ABB=m
-CONFIG_REGULATOR_PALMAS=m
+CONFIG_REGULATOR_PALMAS=y
##
## file: drivers/rtc/Kconfig
diff --git a/debian/installer/armhf/modules/armhf-armmp/mmc-modules b/debian/installer/armhf/modules/armhf-armmp/mmc-modules
index 5718bd2..6ebd458 100644
--- a/debian/installer/armhf/modules/armhf-armmp/mmc-modules
+++ b/debian/installer/armhf/modules/armhf-armmp/mmc-modules
@@ -4,3 +4,4 @@ mmci
omap_hsmmc
sunxi-mmc
dw_mmc-exynos
+pbias-regulator
diff --git a/debian/installer/armhf/modules/armhf-armmp/usb-modules b/debian/installer/armhf/modules/armhf-armmp/usb-modules
index 0828c55..f00b24f 100644
--- a/debian/installer/armhf/modules/armhf-armmp/usb-modules
+++ b/debian/installer/armhf/modules/armhf-armmp/usb-modules
@@ -3,7 +3,10 @@ phy-sun4i-usb
dwc3-exynos
dwc3-omap
ohci-exynos
+ohci-omap3
ehci-exynos
+ehci-omap
phy-exynos-usb2
+phy-omap-usb2
ci_hdrc_imx
phy-mxs-usb
>
> Baozi.
>
> ---
> diff -Nru linux-3.16.7/debian/installer/armhf/modules/armhf-armmp/mmc-modules
> linux-3.16.7-ckt2/debian/installer/armhf/modules/armhf-armmp/mmc-modules
> --- linux-3.16.7/debian/installer/armhf/modules/armhf-armmp/mmc-modules
> 2014-09-21 20:04:21.000000000 +0000
> +++ linux-3.16.7-ckt2/debian/installer/armhf/modules/armhf-armmp/mmc-modules
> 2014-12-26 03:16:02.000000000 +0000
> @@ -4,3 +4,5 @@
> omap_hsmmc
> sunxi-mmc
> dw_mmc-exynos
> +pbias-regulator
> +palmas-regulator
> diff -Nru linux-3.16.7/debian/installer/armhf/modules/armhf-armmp/usb-modules
> linux-3.16.7-ckt2/debian/installer/armhf/modules/armhf-armmp/usb-modules
> --- linux-3.16.7/debian/installer/armhf/modules/armhf-armmp/usb-modules
> 2014-12-23 08:10:49.000000000 +0000
> +++ linux-3.16.7-ckt2/debian/installer/armhf/modules/armhf-armmp/usb-modules
> 2014-12-25 02:56:08.000000000 +0000
> @@ -1,8 +1,13 @@
> #include <usb-modules>
> phy-sun4i-usb
> dwc3-exynos
> ohci-exynos
> ehci-exynos
> phy-exynos-usb2
> ci_hdrc_imx
> +phy-mxs-usb
> +dwc3-omap
> +ohci-omap3
> +ehci-omap
> +phy-omap-usb2
> +phy-ti-pipe3
>
>
Reply to: