[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Bug#769589: debian-cd: Please improve .disk/cd_type for non-complete builds

On Mon, Nov 17, 2014 at 07:05:34AM +0100, Petter Reinholdtsen wrote:
>[Steve McIntyre]
>> Interesting change; I'd be tempted to refactor things slightly in
>> the code, but that's a secondary thing. I'm more curious: what are
>> the ramifications for d-i? Have you investigated/tested?
>We use d-i in Debian Edu, and it is able to install from our ISO.  I
>have not investigated more than that.  :) I suspect it might affect
>apt-setup, but have not checked the code.

tack:~/debian/d-i/d-i/packages$ grep -lr cd_type . | less

So yes, it affects apt-setup only.

In 50mirror: it would affect the code that decides whether or not to
offer a network mirror, and the installer priority setting. Appending
extra details on "not_complete" will change things here.

In 41cdset: it won't change anything here, we'll still bail out as
we're not_complete.

In 10apt-cdrom-setup: again, appending to "not_complete" will break
the logic there that turns off the CD source for netinst images.

I think you need to make some changes in d-i too before I'm happy to
take this patch, sorry.

Steve McIntyre, Cambridge, UK.                                steve@einval.com
"When C++ is your hammer, everything looks like a thumb." -- Steven M. Haflich

Reply to: