[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: d-i bugs and freeze

Steven Chamberlain <steven@pyro.eu.org> (2014-10-31):
> Hi KiBi,
> I'd like to fix d-i bugs, but I wonder how the impending freeze
> affects this:
>   * may I still commit a non-RC bug fix to master
>   * is it likely to be uploaded to sid
>   * is it likely to get an unblock

Yes to all (but of course “likely” depends on what the actual fix is
about, how it's implemented, and how confident I feel with it).

> As a real example, right now I have a fix for an issue mentioned in
> two install reports, which I'd consider severity 'important'.
> https://lists.debian.org/debian-bsd/2014/09/msg00125.html
> | grub-mkdevicemap (in /target chroot) did not detect any (virtio)
> | hard disks.  I had to "Enter device manually" in the dialog and
> | specify /dev/vtbd0, which worked.
> https://lists.debian.org/debian-bsd/2014/10/msg00445.html
> | Apart from that, the grub install step was not able to find the
> | disk/partition by default, so I had to specify it in the prompt as
> | '/dev/xbd0'.

It might be a good idea to have a bug report (pointing at these list
messages) and a bug closure in the changelog. This particular case
looks easy enough but I'd rather have that as a general guideline,
which is going to help unblock reviews.

> And the rather simple change is attached.  Not sure what to do.

Fix it? :) You seem to be missing backslashes.

>  device_to_disk () {
>  	echo "$1" | \
> -		sed 's:\(/dev/\(cciss\|ida\|rs\)/c[0-9]d[0-9][0-9]*\|/dev/mmcblk[0-9]\|/dev/\(ad\|ada\|da\)[0-9]\+\|/dev/[hs]d[0-9]\+\|/dev/[a-z]\+\).*:\1:'
> +		sed 's:\(/dev/\(cciss\|ida\|rs\)/c[0-9]d[0-9][0-9]*\|/dev/mmcblk[0-9]\|/dev/\(ad\|ada\|da|vtbd|xbd\)[0-9]\+\|/dev/[hs]d[0-9]\+\|/dev/[a-z]\+\).*:\1:'
                                                                                                ^^   ^^  ^    ^

Push to master once it's fixed and maybe Christian will upload it when
he notices the unreleased changes.


Attachment: signature.asc
Description: Digital signature

Reply to: