Bug#762007: Kernel command line handling change breaks d-i user-params functionality
severity 762007 important
tag 762007 +pending
clone 762007 -1 -2 -3
reassign -1 src:debian-installer
title -1 debian-installer: Please use "---" not "--" on installer's kernel command line
block -1 by 762007
reassign -2 src:debian-cd
title -2 debian-cd: Please use "---" not "--" on installer's kernel command line
block -2 by 762007
reassign -3 src:installation-guide
title -3 installation-guide: Please use "---" not "--" on installer's kernel command line
block -3 by 762007
thanks
TL;DR for the above packages: A kernel change broke the use of "--" on
the kernel command line as a separator for d-i user-params purposes
(i.e. the bit which affects the installer but is also propagated to the
installed system). We now support "---" as well and should use that
wherever we currently use "--".
On Thu, 2014-10-09 at 08:48 +0100, Ian Campbell wrote:
> I've left a complete install running but I'm pretty confident that it
> will succeed.
It did. So I have pushed the patch to git.
> As well as this fix I think we need to investigate which of these need
> fixing too (i.e. with s/--/---/ in appropriate places):
> * The pxe/grub etc configs in debian-installer.git
> * Debian-cd
> * Installation guide
I've assigned clones of this bug to these.
> I'm sure that list must be incomplete but it was all I could come up
> with. Sadly, as you might imagine, "--" is not terribly amenable to grep
> or codesearch.d.o.
>
> Ian.
>
> >
> > diff --git a/user-params b/user-params
> > index 53677b5..2d41e05 100755
> > --- a/user-params
> > +++ b/user-params
> > @@ -14,7 +14,7 @@ for item in $(sed -e 's/[^ =]*="[^"]*[ ][^"]*"//g' \
> > # Remove trailing '?' for debconf variables set with '?='
> > var="${var%\?}"
> >
> > - if [ "$item" = "--" ]; then
> > + if [ "$item" = "--" ] || [ "$item" = "---" ]; then
> > inuser=1
> > collect=""
> > elif [ "$inuser" ]; then
> >
> > Ian.
> >
> >
>
>
Reply to: