[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#763073: marked as done (partman-md places first line of mdadm.conf to wrong file)

Your message dated Mon, 06 Oct 2014 06:20:30 +0000
with message-id <E1Xb1eo-0007Mv-Ir@franck.debian.org>
and subject line Bug#763073: fixed in partman-md 71
has caused the Debian Bug report #763073,
regarding partman-md places first line of mdadm.conf to wrong file
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
763073: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=763073
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: partman-md
Version: 70
Severity: normal
Tags: patch

finish-install.d/65partman-md reads:

 CF=/target/etc/mdadm/mdadm.conf
 if ... then
        mkdir -p /target/etc/mdadm
        echo "# Autogenerated by partman-md. See mdadm.conf(5) for more details on this file." > /etc/mdadm.conf
        echo "DEVICE partitions" >> $CF
        ...

and all subsequent lines adds information to $CF.
But the very first line, the "Autogenerated.." header
line, is put into d-i filesystem, where it is not used.
The intention was, obviously, to put it to target
mdadm.conf, ie, to $CF.

Appended patch does just that.  While at it, it also
replaces argument of mkdir to be ${CF%/*}, to keep
path info in only one place, in CF variable assignment
( ${var%pattern} construct works with dash too).

Thanks,

/mjt

--- partman-md/finish-install.d/65partman-md.orig
+++ partman-md/finish-install.d/65partman-md
@@ -2,8 +2,8 @@
 CF=/target/etc/mdadm/mdadm.conf
 if [ ! -s "$CF" ] && [ -e /proc/mdstat ] && \
    grep ^md /proc/mdstat >/dev/null; then
-	mkdir -p /target/etc/mdadm
-	echo "# Autogenerated by partman-md. See mdadm.conf(5) for more details on this file." > /etc/mdadm.conf
+	mkdir -p ${CF%/*}
+	echo "# Autogenerated by partman-md. See mdadm.conf(5) for more details on this file." > $CF
 	echo "DEVICE partitions" >> $CF
 	if [ "$(udpkg --print-os)" = "kfreebsd" ]; then
 		mount -t linprocfs proc /target/proc

--- End Message ---
--- Begin Message --- 
Source: partman-md
Source-Version: 71

We believe that the bug you reported is fixed in the latest version of
partman-md, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 763073@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Christian Perrier <bubulle@debian.org> (supplier of updated partman-md package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Mon, 06 Oct 2014 08:09:01 +0200
Source: partman-md
Binary: partman-md
Architecture: source all
Version: 71
Distribution: unstable
Urgency: low
Maintainer: Debian Install System Team <debian-boot@lists.debian.org>
Changed-By: Christian Perrier <bubulle@debian.org>
Description:
 partman-md - Add to partman support for MD (udeb)
Closes: 763073
Changes:
 partman-md (71) unstable; urgency=low
 .
   [ Cyril Brulebois ]
   * Ajust mdadm.conf generation, thanks to Michael Tokarev (Closes: #763073):
     - Send the first line (comment) to the appropriate file, using $CF.
     - Stop hardcoding the parent directory, compute it from $CF.
Checksums-Sha1:
 cd2c21301d8a7152c2625e3213fa4aa9dbd55379 1641 partman-md_71.dsc
 133dc10a727521249c6b84fd315dff745c1e7014 179936 partman-md_71.tar.xz
 e211c5b05b53a7f4c99e48c45d2b617b128afa7e 240666 partman-md_71_all.udeb
Checksums-Sha256:
 8d73d2707bcf85fdef70a70ea10384be9c79d6fb336e096d64072c64ce6363f7 1641 partman-md_71.dsc
 04bdcaf976b6ca15c1ed0642481fd965dc5bcd40c38ac8a2730acbe272ed7744 179936 partman-md_71.tar.xz
 3d2ea5452d03f6becb14a94502aa191119682a2b2c786ceeab4d0a7596a6352c 240666 partman-md_71_all.udeb
Files:
 173615c9c260326e92a5f20e515da54a 240666 debian-installer standard partman-md_71_all.udeb
 8925b2249ba4d9038c185a260c3c5c6e 1641 debian-installer standard partman-md_71.dsc
 ea7f612130a869ff1b54c0bf6dac9699 179936 debian-installer standard partman-md_71.tar.xz

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)

iQIcBAEBCAAGBQJUMjJPAAoJEIcvcCxNbiWof7QP+QE1HAwrBCdcW8urfJGqGbi4
U1a8UFYkQaUtCiRHmNvMmEM0b7+XAlU2jD5tbixKStORVdYUKoLOfJa6mlJ47Gor
Z/D3onDX/SZZ8mUhfqKR+bYFIMgZotq/hTD4qkp4F3v75lXNRSiFMSbgP0miuhbf
ceQcLccTzmekjCiP5C1qBUmxoDb9kisRxQ+pcThoGgKF5ukpwpy8WEHq22yrpoe0
0tR5e4o7MyybzSE/p2sEASntBMbA05UDa4MsB8OcfYbSzxFI+LITrD831lp2EWdR
4ALNz349zbnEDPeHWm+YM4g34nbugF9AzRuqh16AxAJN+2VmUAJ1p2ul7kkyZAuq
wu6UaL3KN+IVx2w45CLxfTy+z3jbu4I9t1Ia1yb14mkD96AjSjlztvzrtSWes9PU
MpvwQZ5DBkWtGO08Jn8smwk6wFLuDe4vFZL/OrtEisR0bulyoLmVgUt1OHnVOuAr
xS+Igcar0xm7ag4jkOOR2e+E0gJyJ2bk+lFSIDB8bRWVxxl9N0Hy0RghDURSLzUC
kRPpzd8tedebrWP04Z7HsiRUZkwthqe48VEty4WJlcjd0+QkXbRhJ8S/kd+cSdJB
7vwTtExSW1pRFhVC3EFnl0aw3RFf6G6fHWdHB/wGqNcqvCBCDsXfwr4IAoU2b5GW
LGb2NFWDu3G8HEP3rCq8
=FZ8S
-----END PGP SIGNATURE-----

--- End Message ---
Reply to: