[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#763073: partman-md places first line of mdadm.conf to wrong file



Control: tag -1 pending

Michael Tokarev <mjt@tls.msk.ru> (2014-09-27):
> Package: partman-md
> Version: 70
> Severity: normal
> Tags: patch
> 
> finish-install.d/65partman-md reads:
> 
>  CF=/target/etc/mdadm/mdadm.conf
>  if ... then
>         mkdir -p /target/etc/mdadm
>         echo "# Autogenerated by partman-md. See mdadm.conf(5) for more details on this file." > /etc/mdadm.conf
>         echo "DEVICE partitions" >> $CF
>         ...
> 
> and all subsequent lines adds information to $CF.
> But the very first line, the "Autogenerated.." header
> line, is put into d-i filesystem, where it is not used.
> The intention was, obviously, to put it to target
> mdadm.conf, ie, to $CF.
> 
> Appended patch does just that.  While at it, it also
> replaces argument of mkdir to be ${CF%/*}, to keep
> path info in only one place, in CF variable assignment
> ( ${var%pattern} construct works with dash too).

Thanks, pushed to master.

Not a blocker for Jessie Beta 2, but testing/uploading shouldn't hurt
due to the udeb freeze; nothing too dramatic anyway, that it needs to
be fixed urgently…

Mraw,
KiBi.

Attachment: signature.asc
Description: Digital signature


Reply to: