[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#762713: marked as done (debootstrap should set -e)



Your message dated Thu, 25 Sep 2014 05:03:40 +0000
with message-id <E1XX1DQ-00027j-LW@franck.debian.org>
and subject line Bug#762713: fixed in debootstrap 1.0.63
has caused the Debian Bug report #762713,
regarding debootstrap should set -e
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
762713: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=762713
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message ---
Package: debootstrap
Version: 1.0.48+deb7u1
Severity: normal
Tags: d-i patch

Currently debootstrap script starts with "#!/bin/sh -e". This means "-e" option will not be set if debootstrap is started, for example, via "bash /usr/sbin/debootstrap". So, please, apply this patch (more text after patch follows):
>>BEGIN OF PATCH<<

--- /usr/sbin/debootstrap       2013-06-03 19:00:00.000000000 +0400
+++ /tmp/patched        2014-09-24 20:43:06.630438880 +0400
@@ -1,4 +1,6 @@
-#!/bin/sh -e
+#!/bin/sh
+
+set -e
 
 VERSION='1.0.48+deb7u1'
 
>>END OF PATCH<<

Also, let me say why it so important to have "set -e": I discovered http://bugs.debian.org/762304 and then I tried to debug it. I know that "trap" command behaves differently in bash and dash. So, I tried to run debootstrap in bash and I typed: "bash /usr/bin/debootstrap". But this throwed away "-e" option, so debootstrap did not stop after the first error and flooded all my screen with error messages. So, as you can see, there is real use case, where "set -e" is needed.

Also, please make a decision about what is intended use of debootstrap and what is not, In the following list:
1. debootstrap
2. sh /usr/sbin/debootstrap
3. . /usr/sbin/debootstrap (note dot in the begin of line)
4. /vmlinuz init=/usr/sbin/debootstrap
5. /vmlinuz init=/bin/sh /usr/sbin/debootstrap

In the 2, 3, 5 you need "set -e".
In the 3 you need "export PATH".
So, "export PATH" is useless in all cases except for very strange 3, so it is very strange that you have "export PATH" in the sources, but don't have "set -e".

=====

-- System Information:
Debian Release: 7.6
  APT prefers stable-updates
  APT policy: (500, 'stable-updates'), (500, 'stable')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 3.2.0-4-amd64 (SMP w/8 CPU cores)
Locale: LANG=ru_RU.UTF-8, LC_CTYPE=ru_RU.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages debootstrap depends on:
ii  wget  1.13.4-3+deb7u1

Versions of packages debootstrap recommends:
ii  debian-archive-keyring  2012.4
ii  gnupg                   1.4.12-7+deb7u4

debootstrap suggests no packages.

-- no debconf information

==
Askar Safin
http://vk.com/safinaskar
Moscow, Russia
Moscow State University, http://msu.ru , Faculty of Mechanics and Mathematics, Department of Mathematical Logic and Theory of Algorithms

--- End Message ---
--- Begin Message ---
Source: debootstrap
Source-Version: 1.0.63

We believe that the bug you reported is fixed in the latest version of
debootstrap, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 762713@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Christian Perrier <bubulle@debian.org> (supplier of updated debootstrap package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.8
Date: Thu, 25 Sep 2014 06:44:16 +0200
Source: debootstrap
Binary: debootstrap debootstrap-udeb
Architecture: source all
Version: 1.0.63
Distribution: unstable
Urgency: medium
Maintainer: Debian Install System Team <debian-boot@lists.debian.org>
Changed-By: Christian Perrier <bubulle@debian.org>
Description:
 debootstrap - Bootstrap a basic Debian system
 debootstrap-udeb - Bootstrap the Debian system (udeb)
Closes: 762713
Changes:
 debootstrap (1.0.63) unstable; urgency=medium
 .
   [ Joey Hess ]
   * Move set -e out of shebang line. Closes: #762713
Checksums-Sha1:
 068225b2198e089850f57a35476236b93c24a577 1812 debootstrap_1.0.63.dsc
 f282e8b43fe074215ccf5fa9c064b0d04321143c 50092 debootstrap_1.0.63.tar.xz
 5e672cd693fe16b74e4552f0bbc618bc5a65a53a 56832 debootstrap_1.0.63_all.deb
 cf79f7000b717af8737f097fe048c578197ec00b 18228 debootstrap-udeb_1.0.63_all.udeb
Checksums-Sha256:
 671b23987961049ab11037c327c74e186f83c67a90100205bc2419e98a8b800e 1812 debootstrap_1.0.63.dsc
 9ced675f97ceb50077e219f38747d2bcc2e0b91b747d7360add9493c1ede4ad5 50092 debootstrap_1.0.63.tar.xz
 7f21933450d8b97b1ad969d31d57f724bc2284651b51d0d2510bb9e2b301da96 56832 debootstrap_1.0.63_all.deb
 d2da1a78b955e4f7add88123d97270abd68948347e816a98099fabbb7eff46d3 18228 debootstrap-udeb_1.0.63_all.udeb
Files:
 307faa0fd22e1aafeaa23b110040779c 56832 admin extra debootstrap_1.0.63_all.deb
 7bd6a1ad6721cc7d8c9ac637ae478df4 18228 debian-installer extra debootstrap-udeb_1.0.63_all.udeb
 b6db70112c1d2cdf0a4ff1ae8191633f 1812 admin extra debootstrap_1.0.63.dsc
 db85404fba0b76249343d0d1285ed02b 50092 admin extra debootstrap_1.0.63.tar.xz

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)

iQIVAwUBVCOf2YcvcCxNbiWoAQIAZw//W3fe/3s/qnYHQ54NdRT6KjkvWY0LlnBZ
RM+TjleZUK5XmxUojsUbW2wxz8SC9eph/z/2jrP2+81P3m6CX9Y4WErNAIdfYjJV
PD421AGrPOaqO+xQqo+rwvmt1YZeJkhMilpY9zfQQKB2BMUgud39nLhdHvlNttde
mhWQQGJM3NG3usFEpC0SLzrd7E1LxI2ea2fgg/Ba3a8MZVXaXhmrpz3vTZ883viX
EVZLnIxK2vgl+xPsuKcgGONWnvIOJc7x9gKg5huinbpKtBMH3YOyJDeZYoCulhnz
RLgndM26K2R/IgXEtZYIWPpOi8dmbWy060eqje8/c+xh+FKPEhg240txtpALa9/C
6Ddax5kyx8nWY/eG/J1REt7IxI/XV+dCRvlEr5Ihak49ybrNm7e533rOurZF3Gao
7373rG3suezpbyookBlPPAaNUmlIg6iVHZFz+VtSjRaB1XLyWHV0TsMPsmmCoO/h
kH3kZGDMQCbr0zSpRdE5Z2hSsF+FzbGDds1KoODVkLxG4F61VHc46jU8oYqsbVWi
2jMMB1sDdRYtJUD53kgyPpbcnSi8wBzWG2Cs3aqp9yjSv1STf37tIKZrrzi0mLrA
feaD1SoIh5ujCgdiFQCGmBz5389hGZMxBBUUPP0l6j8wg+zfZ4KtQxW/yQpy1jWZ
BPOJswhBbhY=
=exDG
-----END PGP SIGNATURE-----

--- End Message ---

Reply to: