[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#762253: Tasksel 3.25: fails due to wrong apt invocation (missing "-o" in front of additional apt option)



Control: tags -1 patch

On Sat, Sep 20, 2014 at 08:22:31AM +0200, Karsten Merker wrote:

> the upload of tasksel 3.25 has broken tasksel in d-i:
> 
> Sep 20 06:04:28 pkgsel: starting tasksel
> Sep 20 06:04:56 in-target: E
> Sep 20 06:04:56 in-target: :
> Sep 20 06:04:56 in-target: Invalid operation APT::Acquire::Retries=3
> Sep 20 06:04:56 in-target:
> Sep 20 06:04:56 in-target: tasksel: apt-get failed (100)
> Sep 20 06:04:57 main-menu[190]: WARNING **: Configuring 'pkgsel' failed with error code 1
> Sep 20 06:04:57 main-menu[190]: WARNING **: Menu item 'pkgsel' failed.

Attached is a patch to tasksel git to fix this. OK to commit and upload?

Regards,
Karsten
-- 
Gem. Par. 28 Abs. 4 Bundesdatenschutzgesetz widerspreche ich der Nutzung
sowie der Weitergabe meiner personenbezogenen Daten für Zwecke der
Werbung sowie der Markt- oder Meinungsforschung.
>From 4b223c8ed383003c957e755d428be8b311b4ccef Mon Sep 17 00:00:00 2001
From: Karsten Merker <merker@debian.org>
Date: Sat, 20 Sep 2014 12:16:26 +0200
Subject: [PATCH 1/2] tasksel.pl: add missing "-o" parameter when calling apt

This fixes bug #762253.
---
 tasksel.pl | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tasksel.pl b/tasksel.pl
index 2ef0f6b..ffe5486 100755
--- a/tasksel.pl
+++ b/tasksel.pl
@@ -637,7 +637,7 @@ sub main {
 			if exists $options{'debconf-apt-progress'};
 		push @cmd, "--";
 	}
-	push @cmd, qw{apt-get -q -y -o APT::Install-Recommends=true -o APT::Get::AutomaticRemove=true APT::Acquire::Retries=3 install};
+	push @cmd, qw{apt-get -q -y -o APT::Install-Recommends=true -o APT::Get::AutomaticRemove=true -o APT::Acquire::Retries=3 install};
 
 	# And finally, act on selected tasks.
 	if (@tasks_install || @tasks_remove) {
-- 
2.1.0

>From 6191038ff73039bf94eb2971561b0f0fe8613179 Mon Sep 17 00:00:00 2001
From: Karsten Merker <merker@debian.org>
Date: Sat, 20 Sep 2014 12:23:09 +0200
Subject: [PATCH 2/2] Start new changelog entry for tasksel 3.26

---
 debian/changelog | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/debian/changelog b/debian/changelog
index 4846acb..ab63b49 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,11 @@
+tasksel (3.26) UNRELEASED; urgency=medium
+
+  [ Karsten Merker ]
+  * add missing "-o" parameter when calling apt with
+    APT::Acquire::Retries=3. Closes: #762253
+
+ -- Karsten Merker <merker@debian.org>  Sat, 20 Sep 2014 12:19:03 +0200
+
 tasksel (3.25) unstable; urgency=medium
 
   * Switch default desktop to gnome, based on prelimary results from
-- 
2.1.0


Reply to: