[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#761135: archdetect: package rename/package-type change breaks d-i builds



[Cyril Brulebois]
> I disagree that reusing package names across package types is a nice
> thing to do. I very strongly disagree that it's OK to try that when
> we're close to the freeze (and not at the very beginning of the
> release cycle, where it hurts less to upload disruptive changes).

Given that udebs and debs have different name spaces, I do not see any
problem myself with dropping a name from one namespace and introducing
it in another, which is what I did when I renamed archdetect to
archdetect-udeb in the udeb namespace and introduced the archdetect
name into the deb namespace.

The freeze is two months away.  I understand you see the freeze as
very close, while I see it as a bit further away.  I fully respect
your view about the urgenzy, even if I do not quite share it.  I
believe fixing the d-i build could have been done this week (for
example by uploading a new debian-installer package without the kernel
change), and was prepared to get any required fixes in place as soon
as possible.

> As I already mentioned, you had been told in advance more stuff
> would have to be adjusted!

I noticed you mentioned IRC messages I hadn't seen before you
mentioned them here in the mail, so I guess they were said while I was
away from IRC.

I had tested the change, but simply forgot to check the
debian-installer initrd build.  I am still sorry about this.

> Sticking to naming schemes is nice, but that certainly shouldn't be a
> reason for renaming packages and generating more work! You could look
> at the file you modified:
[...]
> *-udeb really isn't mandatory in any way!

Sure, but it is used when there is a deb and an udeb.  The common
naming then is <package> for the deb name space and <package>-udeb for
the udeb namespace.  I did not check them all, but as far as I can
tell, the examples without the '-udeb' ending do not have a package in
the deb namespace.

> So yes, I reverted these changes since renaming is unwarranted,
> already broke things, and might break others; I'm not interested in
> dealing with possible fallouts due to cosmetics.

My approach would have been to fix the remaining issues and keep the
archdetect and archdetect-udeb names, but I'm not starting competing
for commits uploads over this and will try to find time for the fix
after Jessie instead.

-- 
Happy hacking
Petter Reinholdtsen


Reply to: