[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#680542: marked as done (partman-lvm: Should call apt-install in finish.d)

Your message dated Sun, 7 Sep 2014 20:37:32 +0200
with message-id <20140907183732.GF14886@ulrik.uio.no>
and subject line Re: Bug#680542: partman-lvm: Should call apt-install in finish.d
has caused the Debian Bug report #680542,
regarding partman-lvm: Should call apt-install in finish.d
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
680542: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=680542
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: partman-lvm
Version: 79
Severity: normal
Tags: patch
User: ubuntu-devel@lists.ubuntu.com
Usertags: origin-ubuntu quantal ubuntu-patch

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Unlike all the other partman-$fs, the apt-install call for the $fs
user space tools in partman-lvm is done in post-base-installer.d, instead
of in finish.d.

It should be consistent with all the other partman-$fs tools, and make that
call in finish.d

This affect ubiquity d-i frontend in ubuntu.

I don't see any good reasons why this is done in post-base-installer.d
and ask you to consider moving it to more generic partman location -  finish.d

- -- System Information:
Debian Release: wheezy/sid
  APT prefers quantal-updates
  APT policy: (500, 'quantal-updates'), (500, 'quantal-security'), (500, 'quantal'), (100, 'quantal-backports')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 3.5.0-3-generic (SMP w/4 CPU cores)
Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

*** 0001-Move-apt-install-lvm2-from-post-base-installer.d-to-.patch
- From e60b6add2b44e64a972a91a4838e39fd12f52fa4 Mon Sep 17 00:00:00 2001
From: Dmitrijs Ledkovs <dmitrijs.ledkovs@canonical.com>
Date: Fri, 6 Jul 2012 17:55:26 +0100
Subject: [PATCH] Move apt-install lvm2 from post-base-installer.d to finish.d
 as all other partman-$fs do the same.

- ---
 debian/changelog                    |    7 +++++++
 finish.d/_numbers                   |    1 +
 finish.d/aptinstall_lvm             |   11 +++++++++++
 post-base-installer.d/64partman-lvm |   11 -----------
 4 files changed, 19 insertions(+), 11 deletions(-)
 create mode 100644 finish.d/_numbers
 create mode 100755 finish.d/aptinstall_lvm
 delete mode 100755 post-base-installer.d/64partman-lvm

diff --git a/debian/changelog b/debian/changelog
index b2b0ca2..e487b07 100644
- --- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,10 @@
+partman-lvm (80) UNRELEASED; urgency=low
+
+  * Move apt-install lvm2 from post-base-installer.d to finish.d
+    as all other partman-$fs do the same.
+
+ -- Dmitrijs Ledkovs <dmitrij.ledkov@ubuntu.com>  Fri, 06 Jul 2012 17:36:32 +0100
+
 partman-lvm (79) unstable; urgency=low
 
   * Team upload
diff --git a/finish.d/_numbers b/finish.d/_numbers
new file mode 100644
index 0000000..02a8903
- --- /dev/null
+++ b/finish.d/_numbers
@@ -0,0 +1 @@
+70 aptinstall_lvm
diff --git a/finish.d/aptinstall_lvm b/finish.d/aptinstall_lvm
new file mode 100755
index 0000000..dca4464
- --- /dev/null
+++ b/finish.d/aptinstall_lvm
@@ -0,0 +1,11 @@
+#! /bin/sh
+set -e
+
+if grep -q " device-mapper$" /proc/misc; then
+	# Avoid warnings from lvm2 tools about open file descriptors
+	export LVM_SUPPRESS_FD_WARNINGS=1
+
+	if pvdisplay | grep -iq "physical volume ---"; then
+		apt-install lvm2
+	fi
+fi
diff --git a/post-base-installer.d/64partman-lvm b/post-base-installer.d/64partman-lvm
deleted file mode 100755
index dca4464..0000000
- --- a/post-base-installer.d/64partman-lvm
+++ /dev/null
@@ -1,11 +0,0 @@
- -#! /bin/sh
- -set -e
- -
- -if grep -q " device-mapper$" /proc/misc; then
- -	# Avoid warnings from lvm2 tools about open file descriptors
- -	export LVM_SUPPRESS_FD_WARNINGS=1
- -
- -	if pvdisplay | grep -iq "physical volume ---"; then
- -		apt-install lvm2
- -	fi
- -fi
- -- 
1.7.10.4


-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)

iQIcBAEBCAAGBQJP9xo6AAoJEIh7YGGLPBau+/cP/3Ff4AEPAem4V2OPelO3Pn76
+DpSZWdlIWWur7RXWd1oFgzkTxwcQ/tRSqg0dny8ppiB9CXBKyGu2f0NbcUD0pF6
WrU3bc9yavhzZOdvKSjx2WiwxXVi+jBWBpdGS7DhaUxl/draKnKgiMAmIUNjohJs
M2VD/EuLrXNA7WbvWNpbchsPgOz6QVT3ix7EThFWPLgTgTO1wxcE3FSIAx6Ke0Kg
VaGbL3BhwwxZDgTQPmsfuSz60Q5/Vb7uO1HpvrZa6bqniFaEXD0ZX3SSrZGCNOz3
ALSEgI4RUppGOSqu/8VoKvXG53kIiBaZ7f1U3P5XiwcR9TE6j0huFaLvKqEbWyQg
mR7tikkzjTDekywk3pR80UbX8jOXzItZnYBS9uvLsC0UTeGzOLxdJXe5khfQ7dIp
3kleK399XHEs+Yn8xYm3TxmZXUaK/grINZDJc7tQ24i1vWb3POruXPKMms5ElGf+
ueK/ZvfgP/Xw/+CnZ3IT24JLqg+3j3OAasSZusAQKw9RFEmbxyyV5glZIgBqzBSc
sMXFC0yo99C0t8uoF5RxQf8Ky/CknB21z3K2pGl7Pd6HklpqL6OB8kgwUvtZFyvx
1nD/GgeMyhl5oqxqm6cAVnaENP8VEqXZHvZl9bv8TzoAIPYnQ2cKA3axukk0ddRW
7XjYq+j2CunaELkjpkaK
=LDdJ
-----END PGP SIGNATURE-----

--- End Message ---
--- Begin Message --- 
Version: 86

[Cyril Brulebois]
> Well, it looks to me that figuring that out is a prerequisite to
> pushing the patch…

Exactly.  That was why I was asking here, to see if anyone who knew
would answer.  :)

Anyway, a closer look in the git repo show that a patch for this issue
was commited in version 84 with a small fix in version 86.  Thus,
closing it as fixed.  Sorry for not noticing earlier.

-- 
Happy hacking
Petter Reinholdtsen

--- End Message ---
Reply to: