tag -1 + pending thanks Hi, On Tue, Feb 18, 2014 at 01:01:48PM +0100, Guillem Jover wrote: > Here's a patch series adding data.tar, control.tar and control.tar.xz > support, the uncompressed member support just out of completeness. To > create a deb package with a different control.tar compression you can > use «dpkg-deb --uniform-compression pkg/» for example. > > Note I've only tested «udpkg -c» and «udpkg -f», the changes in unpacking > are pretty obvious, but testing them would be nice. I've also used cat > for the uncompressed members as I didn't think further optimization there > was worth it(?). I've also tried to use the prevailing coding-style, > which in some cases conflicted with the immediate surrounding code. given KiBi's analysis there's no immediate rush to go all-xz for jessie, but we should still land the patches to udpkg, of course. As for the cat: You went from "ar -p %s %s%s|%s -c|tar -x" to "ar -p %s %s%s|%s|tar -x". I guess you could have moved the pipe into the output of decompression_tool as well and do "ar -p %s %s%s%s|tar -x" with "|gunzip -c", "|unxz -c", and "". But then I think your approach is clear to readers, so that's good. ;-) I pushed your patches to the repository. Very much thanks for them. Kind regards Philipp Kern
Attachment:
signature.asc
Description: Digital signature