[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#738923: marked as done (parted3 preparations)

Your message dated Mon, 14 Jul 2014 09:22:43 +0000
with message-id <E1X6cT5-0003ez-Kj@franck.debian.org>
and subject line Bug#738923: fixed in partman-base 174
has caused the Debian Bug report #738923,
regarding parted3 preparations
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
738923: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=738923
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: partman-base
Tags: patch

In preparation for the parted3 transition, this patch removes support
for filesystem creation and checking from parted_server.  The dependency
and linker flag changes can be left out for now and it should still
build against parted2.  They can be added after parted3 has been
uploaded to actually make the switch.


diff -Nru partman-base-172/debian/changelog partman-base-173/debian/changelog
--- partman-base-172/debian/changelog	2014-01-05 09:20:41.000000000 -0500
+++ partman-base-173/debian/changelog	2014-02-13 10:44:21.000000000 -0500
@@ -1,3 +1,10 @@
+partman-base (173) unstable; urgency=low
+
+  * parted_server: remove support for filesystem create/check/copy
+    and link to libparted2 instead of libparted0.
+
+ -- Phillip Susi <psusi@ubuntu.com>  Wed, 12 Feb 2014 11:57:20 -0500
+
 partman-base (172) unstable; urgency=low
 
   [ Updated translations ]
diff -Nru partman-base-172/debian/control partman-base-173/debian/control
--- partman-base-172/debian/control	2013-07-13 03:07:32.000000000 -0400
+++ partman-base-173/debian/control	2014-02-12 11:57:06.000000000 -0500
@@ -3,7 +3,7 @@
 Priority: standard
 Maintainer: Debian Install System Team <debian-boot@lists.debian.org>
 Uploaders: Anton Zinoviev <zinoviev@debian.org>, Colin Watson <cjwatson@debian.org>, Christian Perrier <bubulle@debian.org>, Max Vozeler <xam@debian.org>
-Build-Depends: debhelper (>= 9), dh-di (>= 2), po-debconf (>= 0.5.0), libparted0-dev (>= 2.2)
+Build-Depends: debhelper (>= 9), dh-di (>= 2), po-debconf (>= 0.5.0), libparted2-dev
 Vcs-Browser: http://anonscm.debian.org/gitweb/?p=d-i/partman-base.git
 Vcs-Git: git://anonscm.debian.org/d-i/partman-base.git
 
diff -Nru partman-base-172/Makefile partman-base-173/Makefile
--- partman-base-172/Makefile	2011-01-18 23:56:34.000000000 -0500
+++ partman-base-173/Makefile	2014-02-12 14:07:57.000000000 -0500
@@ -1,5 +1,5 @@
 CFLAGS=-Wall -Os -D_GNU_SOURCE
-LIBS=-lparted
+LIBS=-lparted -lparted-fs-resize -luuid
 
 all: parted_server parted_devices partmap
 
diff -Nru partman-base-172/parted_server.c partman-base-173/parted_server.c
--- partman-base-172/parted_server.c	2012-07-02 21:01:55.000000000 -0400
+++ partman-base-173/parted_server.c	2014-02-13 10:48:20.000000000 -0500
@@ -258,48 +258,6 @@
         oprintf("%.0f %s\n", 1000 * timer->frac, timer->state_name);
 }
 
-/* Like ped_file_system_create but automaticaly creates PedTimer */
-PedFileSystem *
-timered_file_system_create(PedGeometry *geom, PedFileSystemType *type)
-{
-        PedFileSystem *result;
-        PedTimer *timer;
-        start_timer();
-        timer = ped_timer_new(&timer_handler, NULL);
-        result = ped_file_system_create(geom, type, timer);
-        stop_timer();
-        ped_timer_destroy(timer);
-        return result;
-}
-
-/* Like ped_file_system_check but automaticaly creates PedTimer */
-int
-timered_file_system_check(PedFileSystem *fs)
-{
-        int result;
-        PedTimer *timer;
-        start_timer();
-        timer = ped_timer_new(&timer_handler, NULL);
-        result = ped_file_system_check(fs, timer);
-        stop_timer();
-        ped_timer_destroy(timer);
-        return result;
-}
-
-/* Like ped_file_system_copy but automaticaly creates PedTimer */
-PedFileSystem *
-timered_file_system_copy(PedFileSystem *fs, PedGeometry *geom)
-{
-        PedFileSystem *result;
-        PedTimer *timer;
-        start_timer();
-        timer = ped_timer_new(&timer_handler, NULL);
-        result = ped_file_system_copy(fs, geom, timer);
-        stop_timer();
-        ped_timer_destroy(timer);
-        return result;
-}
-
 /* Like ped_file_system_resize but automaticaly creates PedTimer */
 int
 timered_file_system_resize(PedFileSystem *fs, PedGeometry *geom)
@@ -940,14 +898,6 @@
                         ped_file_system_close(fs);
                 return false;
         }
-        log("try to check the file system for errors");
-        if (NULL != fs && !timered_file_system_check(fs)) {
-                /* TODO: inform the user. */
-                log("uncorrected errors");
-                ped_file_system_close(fs);
-                return false;
-        }
-        log("successfully checked");
         if (part->type & PED_PARTITION_LOGICAL)
                 maximize_extended_partition(disk);
         if (!ped_disk_set_partition_geom(disk, part, constraint, start, end))
@@ -1867,83 +1817,6 @@
 }
 
 void
-command_check_file_system()
-{
-        char *id;
-        PedPartition *part;
-        PedFileSystem *fs;
-        char *status;
-        scan_device_name();
-        if (dev == NULL)
-                critical_error("The device %s is not opened.", device_name);
-        open_out();
-        if (1 != iscanf("%as", &id))
-                critical_error("Expected partition id");
-        log("command_check_file_system(%s)", id);
-        part = partition_with_id(disk, id);
-        free(id);
-        fs = ped_file_system_open(&(part->geom));
-        if (NULL == fs)
-                status = "n/c";
-        else {
-                if (timered_file_system_check(fs))
-                        status = "good";
-                else
-                        status = "bad";
-                ped_file_system_close(fs);
-        }
-        oprintf("OK\n");
-        oprintf("%s\n", status);
-}
-
-void
-command_create_file_system()
-{
-        char *id;
-        PedPartition *part;
-        char *s_fstype;
-        PedFileSystemType *fstype;
-        PedFileSystem *fs;
-        scan_device_name();
-        if (dev == NULL)
-                critical_error("The device %s is not opened.", device_name);
-        change_named(device_name);
-        open_out();
-        if (2 != iscanf("%as %as", &id, &s_fstype))
-                critical_error("Expected partition id and file system");
-        log("command_create_file_system(%s,%s)", id, s_fstype);
-        part = partition_with_id(disk, id);
-        if (part == NULL)
-                critical_error("No such partition: %s", id);
-        free(id);
-
-        mangle_fstype_name(&s_fstype);
-
-        fstype = ped_file_system_type_get(s_fstype);
-        if (fstype == NULL)
-                critical_error("Bad file system type: %s", s_fstype);
-        ped_partition_set_system(part, fstype);
-        deactivate_exception_handler();
-        if ((fs = timered_file_system_create(&(part->geom), fstype)) != NULL) {
-                ped_file_system_close(fs);
-                /* If the partition is at the very start of the disk, then
-                 * we've already done all the committing we need to do, and
-                 * ped_disk_commit_to_dev will overwrite the partition
-                 * header.
-                 */
-                if (part->geom.start != 0)
-                        ped_disk_commit_to_dev(disk);
-        }
-        activate_exception_handler();
-        free(s_fstype);
-        oprintf("OK\n");
-        if (fs != NULL)
-                oprintf("OK\n");
-        else
-                oprintf("failed\n");
-}
-
-void
 command_new_label()
 {
         PedDiskType *type;
@@ -2280,46 +2153,6 @@
 }
 
 void
-command_copy_partition()
-{
-        char *srcid, *srcdiskid, *destid;
-        PedPartition *source, *destination;
-        PedDisk *srcdisk;
-        PedFileSystem *fs;
-        scan_device_name();
-        if (dev == NULL)
-                critical_error("The device %s is not opened.", device_name);
-        assert(disk != NULL);
-        log("command_copy_partition()");
-        change_named(device_name);
-        open_out();
-        if (3 != iscanf("%as %as %as", &destid, &srcdiskid, &srcid))
-                critical_error("Expected id device_identifier id");
-        if (!device_opened(srcdiskid))
-                critical_error("The device %s is not opened.", srcdiskid);
-        srcdisk = disk_named(srcdiskid);
-        if (srcdisk == NULL)
-                critical_error("The source device has label");
-        source = partition_with_id(srcdisk, srcid);
-        destination = partition_with_id(disk, destid);
-        if (source == NULL)
-                critical_error("No source partition %s", srcid);
-        if (destination == NULL)
-                critical_error("No destination partition %s", destid);
-        fs = ped_file_system_open(&(source->geom));
-        if (fs != NULL) {
-                /* TODO: is ped_file_system_check(fs, ...) necessary? */
-                if (timered_file_system_copy(fs, &(destination->geom)))
-                        ped_partition_set_system(destination, fs->type);
-                ped_file_system_close(fs);
-        }
-        oprintf("OK\n");
-        free(destid);
-        free(srcdiskid);
-        free(srcid);
-}
-
-void
 command_get_label_type()
 {
         log("command_get_label_type()");
@@ -2554,10 +2387,6 @@
                         command_get_file_system();
                 else if (!strcasecmp(str, "CHANGE_FILE_SYSTEM"))
                         command_change_file_system();
-                else if (!strcasecmp(str, "CHECK_FILE_SYSTEM"))
-                        command_check_file_system();
-                else if (!strcasecmp(str, "CREATE_FILE_SYSTEM"))
-                        command_create_file_system();
                 else if (!strcasecmp(str, "NEW_LABEL"))
                         command_new_label();
                 else if (!strcasecmp(str, "NEW_PARTITION"))
@@ -2573,8 +2402,6 @@
                         command_virtual_resize_partition();
                 else if (!strcasecmp(str, "GET_VIRTUAL_RESIZE_RANGE"))
                         command_get_virtual_resize_range();
-                else if (!strcasecmp(str, "COPY_PARTITION"))
-                        command_copy_partition();
                 else if (!strcasecmp(str, "GET_LABEL_TYPE"))
                         command_get_label_type();
                 else if (!strcasecmp(str, "IS_BUSY"))

Attachment: signature.asc
Description: OpenPGP digital signature


--- End Message ---
--- Begin Message --- 
Source: partman-base
Source-Version: 174

We believe that the bug you reported is fixed in the latest version of
partman-base, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 738923@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Colin Watson <cjwatson@debian.org> (supplier of updated partman-base package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Mon, 14 Jul 2014 09:41:29 +0100
Source: partman-base
Binary: partman-base partman-utils
Architecture: source i386
Version: 174
Distribution: unstable
Urgency: low
Maintainer: Debian Install System Team <debian-boot@lists.debian.org>
Changed-By: Colin Watson <cjwatson@debian.org>
Description:
 partman-base - Partition the storage devices (partman) (udeb)
 partman-utils - Utilities related to partitioning (udeb)
Closes: 738923
Changes:
 partman-base (174) unstable; urgency=low
 .
   [ Phillip Susi ]
   * parted_server: Remove support for filesystem create/check/copy, which is
     no longer supported in parted 3 (closes: #738923).
 .
   [ Colin Watson ]
   * Convert to autoconf/automake, allowing us to detect whether libparted >=
     3.1 is present at build time and only link with -lparted-fs-resize in
     that case.
   * Remove support for CHECK_FILE_SYSTEM, CREATE_FILE_SYSTEM, and
     COPY_PARTITION from partman-command, matching changes to parted_server.
Checksums-Sha1:
 6afc21348fd01b7d4995108ab89198271da8b5b6 1900 partman-base_174.dsc
 2527fe4713d3d97ac4c9ce2cf62bca054acf0e7f 171988 partman-base_174.tar.xz
 f87fb2a1ecf0ca4c2c44f52ca937a5662377a4e7 178648 partman-base_174_i386.udeb
 500c0c496afb56807d8249353ce72bf06b17ba05 3356 partman-utils_174_i386.udeb
Checksums-Sha256:
 b6616d3012c54ae61ed4359c465c8c50ab72ede98e6c5695d1f32ebc72923531 1900 partman-base_174.dsc
 69aab7c6d078a92543f9cea4a9bd0c0d3f3e08f760635eb2c7da3fa65ca5c18a 171988 partman-base_174.tar.xz
 c77979532fb8316ca77ee22143acb31d7bbd63f2d995f34a5d3d7efd2f92b99b 178648 partman-base_174_i386.udeb
 fbd6fe7c514f7078dd57f2ab4aeeb82ae480288e243f4a53aa88ed40f48c3540 3356 partman-utils_174_i386.udeb
Files:
 7b79ad4d817f886660e4fc2892a40e0d 178648 debian-installer standard partman-base_174_i386.udeb
 a2721ce1bbc2615f714140a725af15ce 3356 debian-installer extra partman-utils_174_i386.udeb
 4f1fd2e8b955164c77559fbcdde53c86 1900 debian-installer standard partman-base_174.dsc
 10818bf52066fe25d565c3fb6186d3ec 171988 debian-installer standard partman-base_174.tar.xz

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
Comment: Colin Watson <cjwatson@debian.org> -- Debian developer

iQIVAwUBU8Oayzk1h9l9hlALAQjADQ//XiDWnrXR1IIJZWt/s9aAdSr3UUyiHmst
9Sb7x7Wek8Hf9L9g+rmOJ6KJtFqx2Fvlg2ZCD/cy+NarheSVKtuQ7uCvjUmZG6q3
+MozAs3PHVeunsyWcvP9MlpBABIHfgPnoo8B/dcuvLEzVRfSno4ObULEsO8gy+EO
xSJCGv3LMedVjbT22KOtQn9kdDetJbL1GYgkMijKSUFjCqP4ijo4V0KkmFUxNUKy
rjzkVHiCYF7UAF7RagDhxHiiuodxxS3oNa+Vx4aj+/3bF1LxOxWDPgM3VvDnIlVP
G+o0Da2kYmUeiKN0K12gBaXc1eNfyIqBMEdkcW5ESQqqboQcbOrPU8vH+8nUDEMn
+/5QWjWVB574iJmnGmgL8ZxajFZ2AmQowV7R1YUj80vsN3BIhjfJbyRZjRz1mN9l
lO6RZy5Al1Gl6ornhyi67g5FHpyaqMuhq7y49eUakoYYgdf5Rv2C4/C6h4ENSl70
yHQRkUN5QRGuefuuyvTijQQsmDIB3nMdQoIa5/yb1Oj1CsQhcccC/3cXmF2pkTNt
oumQbywxmgRE5OLrBNSb+Et0zrLXtDNKvLJQtrqP+/Nb4BwOeMT1ah/7YtmIQJIX
I8Nx15WcKvQUZmM9ogCSU00nzfz+KAOLJP9K3L1dcRJXvwz8601niQmEMgTBiwTA
uBB3nzlWhxo=
=hcU+
-----END PGP SIGNATURE-----

--- End Message ---
Reply to: