[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#751816: flash-kernel and dtb

On Fri, 2014-07-11 at 16:33 -0700, Vagrant Cascadian wrote:
> Control: tags 751816 patch
> On Tue, Jul 08, 2014 at 08:03:30PM +0100, Ian Campbell wrote:
> > I think the patch below resolves the worst issue and it works for me on
> > cubietruck.
> > 
> > The more minor stuff mentioned in that report I'm not sure it is
> > actually worth worrying over. The main one seems to be
> > that /etc/default/flash-kernel:LINUX_KERNEL_CMDLINE is still populated
> > even on systems where there is no way at all for it to get used.
> > 
> > Thoughts on that?
> Looks good to me.

Thanks. I'll try and find time to do an upload ASAP. I think I'll change
the "(Partially addresses #751816)" into a proper closes and leave the
other more minor issues alone unless/until they bite actual users.

> The only improvement I might suggest is deleting the line entirely if
> LINUX_KERNEL_CMDLINE isn't set, but that's a minor point. Would definitely like
> to see the updated flash-kernel hit jessie soon!

You mean the setenv line? I think "setenv bootargs ${bootargs} " should
be harmless enough.

Omitting it would be a bit tricky and would rely on me knowing more
about the supported feature set of each platforms shell or making
flash-kernel more complicated somehow. I don't think it's worth it, what
do you think?


Reply to: