--- Begin Message ---
- To: Debian Bug Tracking System <submit@bugs.debian.org>
- Subject: partman-auto: Installer doesn't reuse EFI system partitions when specified by recipe
- From: Mario Limonciello <Mario_Limonciello@Dell.com>
- Date: Mon, 11 Nov 2013 14:00:53 -0600
- Message-id: <20131111200053.32259.32857.reportbug@serverman>
Package: partman-auto
Version: 114
Severity: normal
Dear Maintainer,
During 4df358695167c0b6e2af5816f364d8a9a734ec05 some support for UEFI installs was added.
Within there was some support for reusing EFI system partitions, but the code was not
complete.
When preseeded with a recipe set to reuse the existing EFI system partition the installer
fails claiming it couldn't find an EFI system partition. Examining closer it's apparent
that the EFI system partiiton was marked as to be formatted rather than reused.
Most of this code came from Ubuntu and this has already been fixed in Ubuntu's partman-auto
package. I've pulled out the two relevant patches that will fix this problem.
I've also applied them to an install of my own and validated that they actually do fix the
behavior.
-- System Information:
Debian Release: wheezy/sid
APT prefers precise-updates
APT policy: (500, 'precise-updates'), (500, 'precise-proposed'), (500, 'precise'), (100, 'precise-backports')
Architecture: amd64 (x86_64)
Kernel: Linux 3.2.0-53-generic (SMP w/16 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
>From 3f84296e7db2a5fe12bcfe57d797f2fefbac58fe Mon Sep 17 00:00:00 2001
From: Mario Limonciello <mario_limonciello@dell.com>
Date: Mon, 4 Nov 2013 18:22:35 -0600
Subject: [PATCH] Add the rest of the support necessary to allow reusing EFI
partitions.
In 4df358695167c0b6e2af5816f364d8a9a734ec05 Steve McIntyre added
initial support for UEFI leveraging a lot of code from Ubuntu.
The modifications made in lib/auto-shared.sh from Ubuntu are also
necessary however for the installer to allow the EFI System Partition
to be reused.
---
lib/auto-shared.sh | 22 +++++++++++++++++++++-
1 file changed, 21 insertions(+), 1 deletion(-)
diff --git a/lib/auto-shared.sh b/lib/auto-shared.sh
index 2b9c42a..4302738 100644
--- a/lib/auto-shared.sh
+++ b/lib/auto-shared.sh
@@ -92,9 +92,29 @@ ensure_primary() {
)"
}
-create_primary_partitions() {
+reuse_partitions() {
cd $dev
+ local scheme
+
+ scheme="$scheme_reused"
+ foreach_partition '
+ id="$(echo " $*" | sed -n '\''s/.* \$reuse{ \([^}]*\) }.*/\1/p'\'')"
+ if [ -z "$id" ]; then
+ db_progress STOP
+ autopartitioning_failed
+ fi
+ setup_partition $id $*
+ # Hack to stop EFI partitions showing up as formatted when
+ # they will actually not be. We do not have a good
+ # interface for this yet.
+ if [ -f $id/method ] && [ "$(cat $id/method)" = efi ] && \
+ [ -f $id/detected_filesystem ]; then
+ rm -f $id/format
+ fi'
+}
+create_primary_partitions() {
+ cd $dev
while [ "$free_type" = pri/log ] && \
echo $scheme | grep -q '\$primary{'; do
pull_primary
--
1.7.9.5
--- End Message ---
--- Begin Message ---
Source: partman-auto
Source-Version: 119
We believe that the bug you reported is fixed in the latest version of
partman-auto, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to 729326@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Colin Watson <cjwatson@debian.org> (supplier of updated partman-auto package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Format: 1.8
Date: Tue, 08 Jul 2014 12:56:28 +0100
Source: partman-auto
Binary: partman-auto
Architecture: source i386
Version: 119
Distribution: unstable
Urgency: medium
Maintainer: Debian Install System Team <debian-boot@lists.debian.org>
Changed-By: Colin Watson <cjwatson@debian.org>
Description:
partman-auto - Automatically partition storage devices (partman) (udeb)
Closes: 729326
Changes:
partman-auto (119) unstable; urgency=medium
.
[ Mario Limonciello ]
* Add the rest of the support necessary to allow reusing EFI partitions
(closes: #729326).
Checksums-Sha1:
e179bf75ef1aff147fd8278e4a7285ab81d72482 1670 partman-auto_119.dsc
e0eef82e30c9294bcf27e6cbff873823947ac00a 104552 partman-auto_119.tar.xz
719e23cbbdc5a735192d5211d88c33b4a7c53481 101266 partman-auto_119_i386.udeb
Checksums-Sha256:
69c0352b27093b1b49a31aa948241671a904028e52221529e41085564008c392 1670 partman-auto_119.dsc
1f05e15e6bfd49e717463495e384ef105c91d63c2871824cd7e83086a114d8e5 104552 partman-auto_119.tar.xz
1439d076d13e51a8579c7773af4e4aecace9ef60384f97718103f7a0b77dc64a 101266 partman-auto_119_i386.udeb
Files:
95f2e6e66232486b25dd0065c6562012 101266 debian-installer standard partman-auto_119_i386.udeb
d8204feb24e9090e5c09099acc64c211 1670 debian-installer standard partman-auto_119.dsc
348552fdd6cf060d1148232b5910e7be 104552 debian-installer standard partman-auto_119.tar.xz
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
Comment: Colin Watson <cjwatson@debian.org> -- Debian developer
iQIVAwUBU7vhozk1h9l9hlALAQi4Zg//RrfjJms3PkhddnDnRukRSlIJnkiAExxr
HHWWyzfND78pktEExgDdRc8vylnwF5VY707OSRfXwlFS9yiIKV/9ml/ucv818Cie
HUDVreSi158eeTmwNpFGwHabNKHnh9319HYIe1JLqYVDz3lwxQIfbHoOp+nwveMQ
fquFM0oRYwkmgAyZdBuY6qunPOmkhsuIy79q7ufwSTI6hU80hz8hW717Exmuziwp
jkuqAn7a6cbb6VrzrJXSH1apwaktW0Co1CiGM3VRMfdlM7isAG3+imL7N8TZxQ0y
mOoiYsBww36YNAcqiOlHzO0mFkePBkd6fXj6IiCiAjXZ+FXu72akVqxMjALd3TlW
WxC0/9Va0yK+WrkOtBJoKifGPPYQpo5GXjFHaG7xUUJY5Rz//soIY00vHcFvrtUv
f6FJ9IfnKgBIIHseED8fX7w0If/+EhnbeXci4quQ/7TzALO/IR3n2umaJD2NhgUk
FgV6KtDGH2c+ge75IVAkYSe156k53P4Tcg/jq0UC6i510bVviAYIjN++G0Heo6DX
d/hNhlO8A7f9vOIxLzAMufHcr5gP7tTejX3PKoLpstOt8Xx6RDQapuaeykTP3S62
5sgGGxXGtJ37W3whY7nDvvvSjhbTGCLKWVKNv/VOpWvX76bVqfAgqvhtCz2IYG9W
J+btdja+N+I=
=MJAo
-----END PGP SIGNATURE-----
--- End Message ---