[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#749228: kbd-chooser: Conflicting return types of loadkeys_wrapper



Package: kbd-chooser
Version: 1.67
Severity: wishlist
Usertags: goto-cc

During a rebuild of all packages in a clean sid chroot (and cowbuilder+pbuilder)
the build failed with the following error. Please note that we use our research
compiler tool-chain (using tools from the cbmc package), which permits extended
reporting on type inconsistencies at link time.

[...]
cc -Wall  -I. -DNDEBUG=1 -fomit-frame-pointer -Os -DAT_KBD  -DUSB_KBD kbd-chooser.c -o kbd-chooser loadkeys.o findfile.o ksyms.o  getfd.o  at-kbd.o  usb-kbd.o -ldebconfclient -ldebian-installer

error: conflicting function declarations "loadkeys_wrapper"
old definition in module kbd-chooser file kbd-chooser.c line 27
signed int (char *)
new definition in module loadkeys file loadkeys.y line 257
void (char *map)
Makefile:95: recipe for target 'kbd-chooser' failed
make[1]: *** [kbd-chooser] Error 64
make[1]: Leaving directory '/srv/jenkins-slave/workspace/sid-goto-cc-kbd-chooser/kbd-chooser-1.67'
dh_auto_build: make -j1 returned exit code 2
debian/rules:3: recipe for target 'build' failed
make: *** [build] Error 2

As the actual implementation does not return a value, and neither does the call
site pick up a return value, this seems to be just a mistake here:

http://sources.debian.net/src/kbd-chooser/1.67/kbd-chooser.c?hl=27#L27

Yet it is worth fixing to avoid any future (invalid) use of the presumed return
value.

Best,
Michael

Attachment: pgpun7oxi87M5.pgp
Description: PGP signature


Reply to: