[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#711586: installation-reports: successful install on thinkpad x230



reassign 711586 netcfg
retritle 711586 Does not copy wireless configuration for network-manager
tags 711586 +patch
thanks

Julien Cristau <jcristau@debian.org> writes:

> On Sat, Jun  8, 2013 at 17:49:11 +0200, Gaudenz Steinlin wrote:
>
>> Julien Cristau <jcristau@debian.org> writes:
>> > UEFI boot went fine after disabling secure boot.  Installer unnecessarily
>> > warned about missing iwlwifi firmware, but IIRC that's getting fixed.
>> > Installed on a WPA network, everything went smoothly.  I thought netcfg
>> > would write out the network config for network-manager to use post install,
>> > but apparently not.
>> 
>> That's odd. This should work. If network-manager is installed, a script
>> in finish-install should copy the NM configuration to the freshly
>> installed system.
>> 
>> Do you still have the installation logs (see /var/log/installer)? Do you
>> see anything about copying network configuration during finish-install
>> in syslog?
>> 
> Here goes:
>
> Jun  8 06:03:17 finish-install: info: Running /usr/lib/finish-install.d/50config-target-network
> Jun  8 06:03:17 finish-install: info: Running /usr/lib/finish-install.d/55netcfg-copy-config
> Jun  8 06:03:17 in-target: Package: network-manager
> Jun  8 06:03:17 in-target: Status: install ok installed
> Jun  8 06:03:17 in-target: Priority: optional
> Jun  8 06:03:17 in-target: Section: net
> Jun  8 06:03:17 in-target: Installed-Size: 4033
> Jun  8 06:03:17 in-target: Maintainer: Utopia Maintenance Team <pkg-utopia-maintainers@lists.alioth.debian.org>
> Jun  8 06:03:17 in-target: Architecture: amd64
> Jun  8 06:03:17 in-target: Version: 0.9.4.0-10
> Jun  8 06:03:17 in-target: Depends: libc6 (>= 2.4), libdbus-1-3 (>= 1.0.2), libdbus-glib-1-2 (>= 0.88), libgcrypt11 (>= 1.4.5), libglib2.0-0 (>= 2.31.8), libgnutls26 (>= 2.12.17-0), libgudev-1.0-0 (>= 146), libnl-3-200 (>= 3.2.7), libnl-genl-3-200 (>=
> Jun  8 06:03:17 in-target: Pre-Depends: dpkg (>= 1.15.7.2)
> Jun  8 06:03:17 in-target: Recommends: policykit-1, ppp (>= 2.4.5), dnsmasq-base, iptables, modemmanager, crda
> Jun  8 06:03:17 in-target: Suggests: avahi-autoipd
> Jun  8 06:03:17 in-target: Breaks: network-manager-gnome (<< 0.9), network-manager-kde (<< 1:0.9), network-manager-openconnect (<< 0.9), network-manager-openvpn (<< 0.9), network-manager-pptp (<< 0.9), network-manager-vpnc (<< 0.9), plasma-widget-netw
> Jun  8 06:03:17 in-target: Conffiles:
> Jun  8 06:03:17 in-target:  /etc/polkit-1/localauthority/10-vendor.d/org.freedesktop.NetworkManager.pkla c95fc58835c3d93739ef3efea8405b15
> Jun  8 06:03:17 in-target:  /etc/init.d/network-manager ff16e17e89d1aa858485570e90f6f04a
> Jun  8 06:03:17 in-target:  /etc/NetworkManager/dispatcher.d/01ifupdown 299819a8e64f00a1edbdfc99d05a8594
> Jun  8 06:03:17 in-target:  /etc/NetworkManager/NetworkManager.conf 914f22205f2ed4d4bc84f3682ecd3153
> Jun  8 06:03:17 in-target:  /etc/dbus-1/system.d/nm-dispatcher.conf 5711a76c31a3763750fe2c331741f679
> Jun  8 06:03:17 in-target:  /etc/dbus-1/system.d/org.freedesktop.NetworkManager.conf 86ea932131ee974e7a5c7b3d7184a583
> Jun  8 06:03:17 in-target:  /etc/dbus-1/system.d/nm-dhcp-client.conf 06b1ecfd8f1fa2a501a5f352e2e5e88e
> Jun  8 06:03:17 in-target:  /etc/dbus-1/system.d/nm-avahi-autoipd.conf 91ab68968b0dc06c3a55b482b50b3028
> Jun  8 06:03:17 in-target: Description: network management framework (daemon and userspace tools)
> Jun  8 06:03:17 in-target:  NetworkManager is a system network service that manages your network devices
> Jun  8 06:03:17 in-target:  and connections, attempting to keep active network connectivity when
> Jun  8 06:03:17 in-target:  available. It manages ethernet, WiFi, mobile broadband (WWAN), and PPPoE
> Jun  8 06:03:17 in-target:  devices, and provides VPN integration with a variety of different VPN
> Jun  8 06:03:17 in-target:  services.
> Jun  8 06:03:17 in-target:  .
> Jun  8 06:03:17 in-target:  This package provides the userspace daemons and a command line interface to
> Jun  8 06:03:17 in-target:  interact with NetworkManager.
> Jun  8 06:03:17 in-target:  .
> Jun  8 06:03:17 in-target:  Optional dependencies:
> Jun  8 06:03:17 in-target:   * policykit-1: Required for reading and writing system connections.
> Jun  8 06:03:17 in-target:   * ppp: Required for establishing dial-up connections (e.g. via GSM).
> Jun  8 06:03:17 in-target:   * dnsmasq-base/iptables: Required for creating Ad-hoc connections and
> Jun  8 06:03:17 in-target:     connection sharing.
> Jun  8 06:03:17 in-target:   * avahi-autoipd: Used for IPv4LL, a protocol for automatic Link-Local IP
> Jun  8 06:03:17 in-target:     address configuration.
> Jun  8 06:03:17 in-target: Homepage: http://www.gnome.org/projects/NetworkManager/
> Jun  8 06:03:17 netcfg[18895]: INFO: Starting netcfg v.1.108 (built 20130407-2200)
> Jun  8 06:03:17 netcfg[18895]: DEBUG: No interface given; clearing /etc/network/interfaces
> Jun  8 06:03:17 netcfg[18895]: DEBUG: Writing informative header
> Jun  8 06:03:17 netcfg[18895]: DEBUG: Success!
> Jun  8 06:03:17 netcfg[18895]: DEBUG: Writing loopback interface
> Jun  8 06:03:17 netcfg[18895]: DEBUG: Success!

So it seems that the check if network-manager is installed fails. I'm
currently offline, but I think I found the bug. In commit
c7d87b7c6a7a91e2844757218e7162295f67e3e0 the detection was changed to
grep the output of "dpkg-query -s" but because of the use of in-target,
the output only goes to the log and not to stdout. So the test for
network-manager always fails.

The attached (untested) patch should fix this. We might want to fix this
in stable too.

Gaudenz

>From 39596ed1256bd941b5c2f4c65c1ec1263160a54e Mon Sep 17 00:00:00 2001
From: Gaudenz Steinlin <gaudenz@soziologie.ch>
Date: Sat, 22 Jun 2013 12:54:59 +0200
Subject: [PATCH] Fix network manager detection

in-target does not pass standard output of the process called by
default. Add --pass-stdout to make the grep actually work.
---
 finish-install.d/55netcfg-copy-config |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/finish-install.d/55netcfg-copy-config b/finish-install.d/55netcfg-copy-config
index 507a3cd..a3275a5 100755
--- a/finish-install.d/55netcfg-copy-config
+++ b/finish-install.d/55netcfg-copy-config
@@ -18,7 +18,7 @@ if [ ! -e $FILE_NETCFG_CONNECTION_TYPE ]; then
 fi
 
 # Flag to determine whether Network Manager is installed.
-if in-target dpkg-query -s network-manager 2>/dev/null | grep -q '^Status: install ok installed'; then
+if in-target --pass-stdout dpkg-query -s network-manager 2>/dev/null | grep -q '^Status: install ok installed'; then
 	NM_IS_INSTALLED=true
 else
 	NM_IS_INSTALLED=false
-- 
1.7.10.4


-- 
Ever tried. Ever failed. No matter.
Try again. Fail again. Fail better.
~ Samuel Beckett ~

Reply to: