[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#693839: debian-installer: kernel install fails on armel buffalo linkstation pro, missing uboot-mkimage



Martin Michlmayr <tbm@cyrius.com> (04/06/2013):
> * Martin Michlmayr <tbm@cyrius.com> [2013-01-02 19:37]:
> > > > Well, I even moved it to Depends in my commit. I'm not sure it is a
> > > > good idea to rely on Recommends being installed if the mkimage
> > > > program is required in some situations.
> > 
> > I disagree.  flash-kernel maintains a database with information about
> > each device, including a list of required packages.  It will install
> > those required packages.  u-boot-tools is listed for the Linkstation,
> > so the real question is why it's not being installed.
> 
> I just received several bug reports about this issue and decided to
> investigate.

Many thanks!

> The flash-kernel database files says:
> # somewhat RFC2822 based, but case sensitive, not tolerant to spaces etc.
>                               ^^^^^^^^^^^^^^
> 
> The flash-kernel-installer postinst is looking for Required-Packages,
> but several devices use Required-packages (note the lower case
> "packages").
> 
> The fix is a simple s/Required-packages/Required-Packages/, and we
> have to apply it both to unstable and wheezy (as installations fail
> without this fix).

Maybe we should also perform a .db check at build time, so that any
new such items would be spotted early? The following shell snippet
seems to do the trick, and could be added to debian/rules, causing
non-zero exit in case there are some hits?

$ for i in Optional Required; do ok=$(grep -c ^$i-Packages db/all.db); all=$(grep -i -c ^$i-Packages db/all.db); if [ $ok != $all ]; then echo "Wrong case for $((all-ok)) $i-Packages fields in db/all.db"; fi; done
Wrong case for 12 Required-Packages fields in db/all.db

Feel free to add that to master if you like it, and upload the
resulting package to unstable. I can take care of preparing the wheezy
branch and the wheezy pu bug report.

Mraw,
KiBi.

Attachment: signature.asc
Description: Digital signature


Reply to: