[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#731345: flash-kernel: add support for DT based kernels on Sheeva Plug



On 12/05/2013 12:34 PM, Martin Michlmayr wrote:
> * Marc Kleine-Budde <mkl@blackshift.org> [2013-12-05 11:49]:
>> That's no option, as non DT Sheeva Plug support has been removed from
>> the kernel in ffbc50663b69462adc9d97b93b6b92c4fe74b94c:
>>
>> ffbc506 ARM: kirkwood: remove support for legacy booting of Sheevaplug
> 
> Interesting.  I thought they promised not to remove non-DT support for
> existing devices.

I personally don't mind, if it's removed once the DT works properly.

> Anyway, Marc, so thanks for your patch.  I wonder if it makes sense to
> add a check to flash-kernel whether DT is required or not.  i.e. that
> flash-kernel would append the DT blob on 3.12+ kernels on SheevaPlug
> but not on previous kernels.

Yes, sounds like the way to go. Otherwise you have to tie certain
flash-kernel versions to the non-DT and DT kernels. This will probably
not scale when more no-DT board are removed from the kernel.

Where should this information go? What about adding another field to
all.db which limits an entry to certain kernel versions? Something like
this:

Machine: Marvell SheevaPlug Reference Board
Kernel-Flavors: kirkwood
Kernel-Version: < 3.12
U-Boot-Kernel-Address: 0x00008000
U-Boot-Initrd-Address: 0x0
Boot-Kernel-Path: /boot/uImage
Boot-Initrd-Path: /boot/uInitrd
Required-Packages: u-boot-tools
Bootloader-Sets-Root: no

Machine: Marvell SheevaPlug Reference Board
Kernel-Flavors: kirkwood
Kernel-Version: >= 3.12
DTB-Id: kirkwood-sheevaplug.dtb
DTB-Append: yes
U-Boot-Kernel-Address: 0x00008000
U-Boot-Initrd-Address: 0x0
Boot-Kernel-Path: /boot/uImage
Boot-Initrd-Path: /boot/uInitrd
Boot-DTB-Path: dtb
Required-Packages: u-boot-tools
Bootloader-Sets-Root: no

Marc


Attachment: signature.asc
Description: OpenPGP digital signature


Reply to: