Bug#724931: Please include the patch in git
Hi,
this is now the second time that I did not get your mail. If you have
any idea what could cause that, please let me know, because it is not
really practical to always check bugs.debian.org.
On Topic: It's always better, if more people look at a patch, so I'd be
grateful for KiBi's thoughts on it, especially concerning the effects
for kFreeBSD, since I could not test these, because I did not manage to
unpack the initrd from the kFreeBSD ISO.
I don't know really what you mean by invasive, but I assume you mean,
that the installer could break, if apt-setup and cdrom-detect are not
both updated at the same time. So let me clarify this a bit:
The functionality to loopmount is not invasive at all, since the
necessary code for this is only executed, if the boot parameter
'loopmount=' is given.
What makes this patch more invasive is the fact that it cleans up the
somewhat messy workaround for bug #608201.
Up to now the situation was, that for every non-CD boot method
(usb-hdd/isohybrid) a template was exported from cdrom-detect and
imported in apt-setup to check there, whether cdset-detection should
automatically (u)mount \cdrom.
I moved the code to determine this to cdrom-detect and only exported the
result (cdrom_mountable) to apt-setup, so that in the future one does
not have to change apt-setup (changes are needed only for cdset
support), if one adds a new boot method.
Thus if not both patches (cdrom-detect and apt-setup) are applied at the
same time, apt-setup will fail, because it looks for a template that
does not exist.
Best regards,
Andreas
Reply to: